* [PATCH] i2c: remove redundant condition
@ 2024-02-24 11:50 zoanana990
2024-03-04 20:54 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: zoanana990 @ 2024-02-24 11:50 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel, zoanana990
I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0
One more condition does not need to be met to obtain the value
Signed-off-by: zoanana990 <harry021633@gmail.com>
---
include/linux/i2c.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
{
- return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+ return (msg->addr << 1) | (msg->flags & I2C_M_RD);
}
u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: remove redundant condition
2024-02-24 11:50 [PATCH] i2c: remove redundant condition zoanana990
@ 2024-03-04 20:54 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2024-03-04 20:54 UTC (permalink / raw)
To: zoanana990; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On Sat, Feb 24, 2024 at 07:50:50PM +0800, zoanana990 wrote:
> I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0
> One more condition does not need to be met to obtain the value
>
> Signed-off-by: zoanana990 <harry021633@gmail.com>
From 'Documentation/process/1.Intro.rst':
It is imperative that all code contributed to the kernel be legitimately
free software. For that reason, code from anonymous (or pseudonymous)
contributors will not be accepted. All contributors are required to "sign
...
Please sign off with your real name.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c: remove redundant condition
@ 2024-03-05 16:56 Hsin-Yu.Chen
2024-03-06 1:32 ` Andi Shyti
0 siblings, 1 reply; 6+ messages in thread
From: Hsin-Yu.Chen @ 2024-03-05 16:56 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel, Hsin-Yu.Chen
I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need one more condition to get the value
Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
---
include/linux/i2c.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
{
- return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+ return (msg->addr << 1) | (msg->flags & I2C_M_RD);
}
u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: remove redundant condition
2024-03-05 16:56 Hsin-Yu.Chen
@ 2024-03-06 1:32 ` Andi Shyti
0 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2024-03-06 1:32 UTC (permalink / raw)
To: Hsin-Yu.Chen; +Cc: wsa+renesas, linux-i2c, linux-kernel
Hi Hsin-Yu,
On Wed, Mar 06, 2024 at 12:56:52AM +0800, Hsin-Yu.Chen wrote:
> I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
> no need one more condition to get the value
this can be written a bit better as:
/no need one more/no need for an additional/
> Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
anyway:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
> ---
> include/linux/i2c.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 652ecb7abeda..363dde9ef94f 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
>
> static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
> {
> - return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
> + return (msg->addr << 1) | (msg->flags & I2C_M_RD);
> }
>
> u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c: remove redundant condition
@ 2024-03-06 4:19 Hsin-Yu.Chen
2024-03-07 8:37 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Hsin-Yu.Chen @ 2024-03-06 4:19 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel, Hsin-Yu.Chen
I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need for an additional condition to obtain the value
Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
---
include/linux/i2c.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
{
- return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+ return (msg->addr << 1) | (msg->flags & I2C_M_RD);
}
u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: remove redundant condition
2024-03-06 4:19 Hsin-Yu.Chen
@ 2024-03-07 8:37 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2024-03-07 8:37 UTC (permalink / raw)
To: Hsin-Yu.Chen; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
On Wed, Mar 06, 2024 at 12:19:00PM +0800, Hsin-Yu.Chen wrote:
> I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
> no need for an additional condition to obtain the value
>
> Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-07 8:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 11:50 [PATCH] i2c: remove redundant condition zoanana990
2024-03-04 20:54 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2024-03-05 16:56 Hsin-Yu.Chen
2024-03-06 1:32 ` Andi Shyti
2024-03-06 4:19 Hsin-Yu.Chen
2024-03-07 8:37 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox