[PATCH] i2c: remove redundant condition

[PATCH] i2c: remove redundant condition

[zoanana990]

I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0
One more condition does not need to be met to obtain the value

Signed-off-by: zoanana990 <harry021633@gmail.com>
---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
-- 
2.38.1

Re: [PATCH] i2c: remove redundant condition

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

On Sat, Feb 24, 2024 at 07:50:50PM +0800, zoanana990 wrote:
> I2C_M_RD is defined as 1, "flag & I2C_M_RD" is 1 or 0
> One more condition does not need to be met to obtain the value
> 
> Signed-off-by: zoanana990 <harry021633@gmail.com>

From 'Documentation/process/1.Intro.rst':

It is imperative that all code contributed to the kernel be legitimately
free software.  For that reason, code from anonymous (or pseudonymous)
contributors will not be accepted.  All contributors are required to "sign
...

Please sign off with your real name.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH] i2c: remove redundant condition

[Hsin-Yu.Chen]

I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need one more condition to get the value

Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
-- 
2.38.1

Re: [PATCH] i2c: remove redundant condition

[Andi Shyti]

Hi Hsin-Yu,

On Wed, Mar 06, 2024 at 12:56:52AM +0800, Hsin-Yu.Chen wrote:
> I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
> no need one more condition to get the value

this can be written a bit better as:

/no need one more/no need for an additional/

> Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>

anyway:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi

> ---
>  include/linux/i2c.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 652ecb7abeda..363dde9ef94f 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
>  
>  static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
>  {
> -	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
> +	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
>  }
>  
>  u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
> -- 
> 2.38.1
> 

[PATCH] i2c: remove redundant condition

[Hsin-Yu.Chen]

I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need for an additional condition to obtain the value

Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>
---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
-- 
2.38.1

Re: [PATCH] i2c: remove redundant condition

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

On Wed, Mar 06, 2024 at 12:19:00PM +0800, Hsin-Yu.Chen wrote:
> I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
> no need for an additional condition to obtain the value
> 
> Signed-off-by: Hsin-Yu.Chen <harry021633@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]