* [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h
@ 2024-03-04 18:03 Andy Shevchenko
2024-03-05 9:15 ` Sean Young
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-03-04 18:03 UTC (permalink / raw)
To: Andy Shevchenko, linux-media, linux-kernel
Cc: Sean Young, Mauro Carvalho Chehab
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/rc/ir-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
index bbc81bed4f90..8afc3cd70b87 100644
--- a/drivers/media/rc/ir-spi.c
+++ b/drivers/media/rc/ir-spi.c
@@ -8,7 +8,6 @@
#include <linux/fs.h>
#include <linux/module.h>
#include <linux/mutex.h>
-#include <linux/of_gpio.h>
#include <linux/regulator/consumer.h>
#include <linux/spi/spi.h>
#include <media/rc-core.h>
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h
2024-03-04 18:03 [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h Andy Shevchenko
@ 2024-03-05 9:15 ` Sean Young
2024-03-05 17:37 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Sean Young @ 2024-03-05 9:15 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it, simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/rc/ir-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index bbc81bed4f90..8afc3cd70b87 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -8,7 +8,6 @@
> #include <linux/fs.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> -#include <linux/of_gpio.h>
This does not build, I get errors saying of_property_read_bool() is undefined.
I think we need linux/of.h instead of linux/of_gpio.h.
Sean
> #include <linux/regulator/consumer.h>
> #include <linux/spi/spi.h>
> #include <media/rc-core.h>
> --
> 2.43.0.rc1.1.gbec44491f096
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h
2024-03-05 9:15 ` Sean Young
@ 2024-03-05 17:37 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-03-05 17:37 UTC (permalink / raw)
To: Sean Young; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
On Tue, Mar 05, 2024 at 09:15:28AM +0000, Sean Young wrote:
> On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
...
> > -#include <linux/of_gpio.h>
>
> This does not build, I get errors saying of_property_read_bool() is undefined.
> I think we need linux/of.h instead of linux/of_gpio.h.
Oh, good catch! The header block there is a mess.
I will replace this patch by something better, I'll Cc you.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-05 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 18:03 [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h Andy Shevchenko
2024-03-05 9:15 ` Sean Young
2024-03-05 17:37 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox