From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"Mario Limonciello" <mario.limonciello@amd.com>,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h
Date: Tue, 5 Mar 2024 18:31:50 +0200 [thread overview]
Message-ID: <ZedI9vCoCf9KtHcr@smile.fi.intel.com> (raw)
In-Reply-To: <14750023-e5fb-45f7-9c28-9510ce5a5994@intel.com>
On Tue, Mar 05, 2024 at 08:21:32AM -0800, Dave Hansen wrote:
> On 3/5/24 08:10, Andy Shevchenko wrote:
> > intel-mid.h is providing some core parts of the South Complex PM,
> > which are usually are not used by individual drivers. In particular,
> > this driver doesn't use it, so simply remove the unused header.
>
> Indeed. intel-mid.h provides a pretty small amount of stuff and it's
> included in quite a few random-looking spots. There's also gunk that's
> only compiled in if CONFIG_X86_INTEL_MID=y so if anyone _did_ somehow
> use any of those functions in generic code, they'd probably be creating
> compile problems.
>
> Any chance you'd like to look a _bit_ more widely and just clean up all
> of the unnecessary intel-mid.h #includes that are scattered around?
All relative patches just have been sent. They are independent, hence sent
separately. Please, apply, what you can, if there is no objection.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-05 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:10 [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 16:21 ` Dave Hansen
2024-03-05 16:31 ` Andy Shevchenko [this message]
2024-03-05 16:34 ` Dave Hansen
2024-03-05 16:36 ` Andy Shevchenko
2024-03-05 16:43 ` Dave Hansen
2024-03-05 16:55 ` Andy Shevchenko
2024-03-25 12:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZedI9vCoCf9KtHcr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mat.jonczyk@o2.pl \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox