Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

Niklas Cassel
2024-03-06T10:55:40Z

On Tue, Mar 05, 2024 at 05:22:24PM -0800, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++

Is there a reason why you didn't patch:
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?

> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index 73b378837da7..b5d379ebe05d 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -3544,6 +3544,11 @@ static struct attribute *host_v2_hw_attrs[] = {
>
> ATTRIBUTE_GROUPS(host_v2_hw);
>
> +static const struct attribute_group *sdev_groups_v2_hw[] = {
> + &sas_ata_sdev_attr_group,
> + NULL
> +};
> +
> static void map_queues_v2_hw(struct Scsi_Host *shost)
> {
> struct hisi_hba *hisi_hba = shost_priv(shost);
> @@ -3585,6 +3590,7 @@ static const struct scsi_host_template sht_v2_hw = {
> .compat_ioctl = sas_ioctl,
> #endif
> .shost_groups = host_v2_hw_groups,
> + .sdev_groups = sdev_groups_v2_hw,
> .host_reset = hisi_sas_host_reset,
> .map_queues = map_queues_v2_hw,
> .host_tagset = 1,
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> index b56fbc61a15a..9b69ea16a1e6 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> @@ -2929,6 +2929,11 @@ static struct attribute *host_v3_hw_attrs[] = {
>
> ATTRIBUTE_GROUPS(host_v3_hw);
>
> +static const struct attribute_group *sdev_groups_v3_hw[] = {
> + &sas_ata_sdev_attr_group,
> + NULL
> +};
> +
> #define HISI_SAS_DEBUGFS_REG(x) {#x, x}
>
> struct hisi_sas_debugfs_reg_lu {
> @@ -3340,6 +3345,7 @@ static const struct scsi_host_template sht_v3_hw = {
> .compat_ioctl = sas_ioctl,
> #endif
> .shost_groups = host_v3_hw_groups,
> + .sdev_groups = sdev_groups_v3_hw,
> .tag_alloc_policy = BLK_TAG_ALLOC_RR,
> .host_reset = hisi_sas_host_reset,
> .host_tagset = 1,
> --
> 2.44.0.278.ge034bb2e1d-goog
>