Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

John Garry
2024-03-07T08:56:53Z

On 06/03/2024 20:56, Igor Pylypiv wrote:
>>> ---
>>> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
>>> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>> Is there a reason why you didn't patch:
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
>>
> I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> that v1 HW doesn't support SATA so I dropped the change.

If you are going to do another spin, then maybe update the commit
message with this.

Thanks,
John