Re: [PATCH v7 7/7] scsi: isci: Add libsas SATA sysfs attributes group

Niklas Cassel
2024-03-06T10:56:05Z

On Tue, Mar 05, 2024 at 05:22:26PM -0800, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
>
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> ---
> drivers/scsi/isci/init.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
> index 6277162a028b..8658dcd61b87 100644
> --- a/drivers/scsi/isci/init.c
> +++ b/drivers/scsi/isci/init.c
> @@ -149,6 +149,11 @@ static struct attribute *isci_host_attrs[] = {
>
> ATTRIBUTE_GROUPS(isci_host);
>
> +static const struct attribute_group *isci_sdev_groups[] = {
> + &sas_ata_sdev_attr_group,
> + NULL
> +};
> +
> static const struct scsi_host_template isci_sht = {
>
> .module = THIS_MODULE,
> @@ -176,6 +181,7 @@ static const struct scsi_host_template isci_sht = {
> .compat_ioctl = sas_ioctl,
> #endif
> .shost_groups = isci_host_groups,
> + .sdev_groups = isci_sdev_groups,
> .track_queue_depth = 1,
> };
>
> --
> 2.44.0.278.ge034bb2e1d-goog
>

Reviewed-by: Niklas Cassel <cassel@kernel.org>