Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

Niklas Cassel
2024-03-07T09:59:39Z

On Thu, Mar 07, 2024 at 08:55:51AM +0000, John Garry wrote:
> On 06/03/2024 20:56, Igor Pylypiv wrote:
> > > > ---
> > > > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> > > > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
> > > Is there a reason why you didn't patch:
> > > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
> > >
> > I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> > that v1 HW doesn't support SATA so I dropped the change.
>
> If you are going to do another spin, then maybe update the commit message
> with this.

+1

John, now I'm curious, do you know why hisi_sas_v1_hw.c is implemented
as a libsas driver (instead of a regular SCSI driver), if it doesn't
support SATA?

Was perhaps v2_hw and v3_hw implemented as a libsas driver first
(since they support SATA), and v1_hw support was added later,
so that it could reuse much of the parts of the existing driver?

Kind regards,
Niklas