From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [SPAM] [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style
Date: Wed, 6 Mar 2024 15:35:56 +0200 [thread overview]
Message-ID: <ZehxPFh2ecxsKsOF@smile.fi.intel.com> (raw)
In-Reply-To: <hwtodfwrgonzzf2dpoqa3b5b3v66ypp7uu7upsnt6dx7weua2f@byxbgpxurhmf>
On Tue, Mar 05, 2024 at 11:52:15PM +0100, Andi Shyti wrote:
> On Tue, Mar 05, 2024 at 07:48:30PM +0200, Andy Shevchenko wrote:
...
> > +static int ir_spi_tx(struct rc_dev *dev, unsigned int *buffer, unsigned int count)
>
> this goes over 80 characters, though. Not an error, but not worth
> a change either.
It's only 82 characters and I consider this as an improvement in readability.
It's quite pity that some of the subsystems are too conservative, hope this
one is not an obstacle for them.
> I'm not going block the patch as the rest is OK.
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thank you!
Btw, don't you want to either add your entry into .mailcap and/or update your
email address in this source file (and maybe others)? I Cc'ed you only after
I looked closer to the sources...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-06 13:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 17:48 [PATCH v1 0/5] media: ir-spi: A few cleanups Andy Shevchenko
2024-03-05 17:48 ` [PATCH v1 1/5] media: ir-spi: Don't use "proxy" headers Andy Shevchenko
2024-03-05 22:44 ` [SPAM] " Andi Shyti
2024-03-05 17:48 ` [PATCH v1 2/5] media: ir-spi: Make use of device properties Andy Shevchenko
2024-03-05 22:45 ` [SPAM] " Andi Shyti
2024-03-05 17:48 ` [PATCH v1 3/5] media: ir-spi: Utilise temporary variable for struct device Andy Shevchenko
2024-03-05 22:47 ` [SPAM] " Andi Shyti
2024-03-05 17:48 ` [PATCH v1 4/5] media: ir-spi: Remove trailing comma in the terminator entry Andy Shevchenko
2024-03-05 22:48 ` Andi Shyti
2024-03-05 17:48 ` [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style Andy Shevchenko
2024-03-05 22:52 ` [SPAM] " Andi Shyti
2024-03-06 13:35 ` Andy Shevchenko [this message]
2024-03-08 12:37 ` Andi Shyti
2024-03-05 22:43 ` [PATCH v1 0/5] media: ir-spi: A few cleanups Andi Shyti
2024-03-11 14:25 ` Andy Shevchenko
2024-03-11 14:50 ` Sean Young
2024-03-11 14:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZehxPFh2ecxsKsOF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox