From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] spi: Fix multiple issues with Chip Select variables and comments
Date: Wed, 6 Mar 2024 22:12:06 +0200 [thread overview]
Message-ID: <ZejOFr4glx-OUSWA@smile.fi.intel.com> (raw)
In-Reply-To: <32c04b04-17c1-40f6-ad57-6c18e47f4842@sirena.org.uk>
On Wed, Mar 06, 2024 at 06:08:43PM +0000, Mark Brown wrote:
> On Wed, Mar 06, 2024 at 05:59:42PM +0200, Andy Shevchenko wrote:
> > There are the following issues with the current code:
> > - inconsistent use of 0xFF and -1 for invalid chip select pin
> > - inconsistent plain or BIT() use
> > - wrong types used for last_cs_* fields
> > - wrong multi-line comment style
> > - misleading or hard-to-understand comments
> >
> > Fix all of these here.
>
> Please don't do this, as covered in submitting-patches.rst submit one
> change per patch. This makes it much easier to review things.
Fine by me, consider this patch as RFC to understand if we want to have this
or not in general. I will rework it, if the idea is acceptable.
If you are fine on the first two, perhaps they can be applied first.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-06 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 15:59 [PATCH v1 0/3] spi: CS code, variables and comments clarification Andy Shevchenko
2024-03-06 15:59 ` [PATCH v1 1/3] spi: Exctract spi_set_all_cs_unused() helper Andy Shevchenko
2024-03-06 15:59 ` [PATCH v1 2/3] spi: Exctract spi_dev_check_cs() helper Andy Shevchenko
2024-03-06 15:59 ` [PATCH v1 3/3] spi: Fix multiple issues with Chip Select variables and comments Andy Shevchenko
2024-03-06 18:08 ` Mark Brown
2024-03-06 20:12 ` Andy Shevchenko [this message]
2024-03-07 15:08 ` Andy Shevchenko
2024-03-06 21:59 ` (subset) [PATCH v1 0/3] spi: CS code, variables and comments clarification Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZejOFr4glx-OUSWA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox