From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, frederic@kernel.org,
boqun.feng@gmail.com, urezki@gmail.com, neeraj.iitr10@gmail.com,
rcu@vger.kernel.org, rostedt@goodmis.org,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>
Subject: Re: [PATCH] [RFC] rcu/tree: Reduce wake up for synchronize_rcu() common case
Date: Fri, 8 Mar 2024 16:05:15 +0100 [thread overview]
Message-ID: <ZespK0CrkVFCu6_p@pc636> (raw)
In-Reply-To: <ccbdf4d4-6972-430c-a479-0d20b318213b@paulmck-laptop>
On Thu, Mar 07, 2024 at 04:06:06PM -0800, Paul E. McKenney wrote:
> On Thu, Mar 07, 2024 at 06:52:14PM -0500, Joel Fernandes wrote:
> > On Thu, Mar 7, 2024 at 6:48 PM Joel Fernandes (Google)
> > <joel@joelfernandes.org> wrote:
> > >
> > > In the synchronize_rcu() common case, we will have less than
> > > SR_MAX_USERS_WAKE_FROM_GP number of users per GP. Waking up the kworker
> > > is pointless just to free the last injected wait head since at that point,
> > > all the users have already been awakened.
> > >
> > > Introduce a new counter to track this and prevent the wakeup in the
> > > common case.
> > >
> > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > > ---
> >
> > Forgot to mention, this is based on the latest RCU -dev branch and
> > passes light rcutorture testing on all configs. Heavier rcutorture
> > testing (60 minutes) was performed on TREE03.
>
> Very good, thank you!
>
> Uladzislau, could you please pull this into the next series you send?
> I can then replace your commits in -rcu with the updated series.
>
Absolutely. I will go through it and send out the next version!
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-03-08 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 23:48 [PATCH] [RFC] rcu/tree: Reduce wake up for synchronize_rcu() common case Joel Fernandes (Google)
2024-03-07 23:52 ` Joel Fernandes
2024-03-08 0:06 ` Paul E. McKenney
2024-03-08 15:05 ` Uladzislau Rezki [this message]
2024-03-08 17:38 ` Uladzislau Rezki
2024-03-08 21:52 ` Paul E. McKenney
2024-03-09 0:46 ` Joel Fernandes
2024-03-08 22:10 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZespK0CrkVFCu6_p@pc636 \
--to=urezki@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.iitr10@gmail.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox