From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bo Liu <liubo03@inspur.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: stusb160x: convert to use maple tree register cache
Date: Tue, 12 Mar 2024 12:14:39 +0200 [thread overview]
Message-ID: <ZfArD+j5+CwyDBeb@kuha.fi.intel.com> (raw)
In-Reply-To: <20240309071757.3152-1-liubo03@inspur.com>
On Sat, Mar 09, 2024 at 02:17:57AM -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/stusb160x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index 3ab118df1bd4..f3140fc04c12 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -234,7 +234,7 @@ static const struct regmap_config stusb1600_regmap_config = {
> .readable_reg = stusb160x_reg_readable,
> .volatile_reg = stusb160x_reg_volatile,
> .precious_reg = stusb160x_reg_precious,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> };
>
> static bool stusb160x_get_vconn(struct stusb160x *chip)
> --
> 2.18.2
--
heikki
prev parent reply other threads:[~2024-03-12 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 7:17 [PATCH] usb: typec: stusb160x: convert to use maple tree register cache Bo Liu
2024-03-12 10:14 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfArD+j5+CwyDBeb@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liubo03@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox