Re: [PATCH] dt-bindings: usb: typec: anx7688: start a binding document

Krzysztof Kozlowski
2024-02-12T11:16:40Z

On 12/02/2024 12:02, Pavel Machek wrote:
> Hi!
>>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
>>> but I did best I could.
>>>
>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>>
>>
>> You miss proper diffstat which makes reviewing difficult.
>
>> Actually entire patch is corrupted and impossible to apply.
>
> Sorry about that.
>
>> Anyway, where is any user of this? Nothing in commit msg explains
>> this.
>
> User being is worked on:
>
> https://lore.kernel.org/lkml/2024020126-emote-unsubtly-3394@gregkh/T/
>
> Thanks for comments. I'll go through them and try to improve things.

OK, please send bindings patch in the same patchset as the driver.
Preferably first bindings patch, then driver patch(es). The bindings
document ABI exposed by driver, so we expect to see and apply both of
them together (apply through subsystem, so USB in this case).

Best regards,
Krzysztof