From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2019444 for ; Wed, 13 Mar 2024 01:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710293601; cv=none; b=rf64jrRScnM6343Kl40WlkfnwjsTX/buv6LOqMRhXhnELW2GOO5EcShRBQF3y31eqQUq1sxYfVVB5nrw0zd+bZNMS/uKZlOUKl3YNZM1vxgIN5BqqvIODtDJUWGYfgA5FDSS5mhFGJj+68gZtthg5BSBpb0KCHRQrP4px7vqziU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710293601; c=relaxed/simple; bh=j3ePOlDPwLMvVtp9Qk/UQW6OamydjdF2X9e8qHtDcwk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IJHZT14ddkfVk5TUiXdTIGwbce+8Y5NHRgFwczrSMs0AW05uPa5jLvrOSE3qHNhSVBEfWptpH+qmqCJ5NNwn5ofcGsnP274+PywrIpjeq7A54pb6tsavA9h16UN4wY4qyJH1koOCPPlvuEaIbP/ujQGJk/ygaKiWWXNEFPGhRkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kXRC9kdA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kXRC9kdA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3ED8C433C7; Wed, 13 Mar 2024 01:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710293601; bh=j3ePOlDPwLMvVtp9Qk/UQW6OamydjdF2X9e8qHtDcwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kXRC9kdAnXtqXkk8fT0FYLUb79JWdNMfjv53hk+lwLvlKHb4oAdDCwdaiwCsYNkaE YqNbPlCtLiVWMgMpfbTJc8Z/z6KxTFjAinY6L9pNNDuLhVOnA90YQ4OQiDcDNAr5ep ib2pCflpp1XpE6IgRXzEYuveoTmyOUo/uHVgphPYrzdb7imaOLvLC+SmwqspoJiAi5 QMynKW8+uaS7zDRhCF6dYC1sjLM7HU7rwTn6tuhZz/Ma/i7GbFMD9op9VyhoOmdMxN 7O/ZtJ4SK6wkh9JgZpdKCRRYGcyrD08ZKMo6AGBLUK5kfm+rBmSDXuqv/9Bi9eIk2e Us8nQVoJZo+5w== Date: Tue, 12 Mar 2024 18:33:19 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: support .shutdown in f2fs_sops Message-ID: References: <20240229143838.45149-1-chao@kernel.org> <63ece9a0-ccd1-43f7-ab51-cf5adc49be71@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63ece9a0-ccd1-43f7-ab51-cf5adc49be71@kernel.org> Will check this after merge window. On 03/12, Chao Yu wrote: > Ping, > > On 2024/2/29 22:38, Chao Yu wrote: > > Support .shutdown callback in f2fs_sops, then, it can be called to > > shut down the file system when underlying block device is marked dead. > > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/f2fs.h | 2 ++ > > fs/f2fs/file.c | 70 ++++++++++++++++++++++++++++++------------------- > > fs/f2fs/super.c | 6 +++++ > > 3 files changed, 51 insertions(+), 27 deletions(-) > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > index 85eb9a8a5ed3..80789255bf68 100644 > > --- a/fs/f2fs/f2fs.h > > +++ b/fs/f2fs/f2fs.h > > @@ -3506,6 +3506,8 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry, > > struct iattr *attr); > > int f2fs_truncate_hole(struct inode *inode, pgoff_t pg_start, pgoff_t pg_end); > > void f2fs_truncate_data_blocks_range(struct dnode_of_data *dn, int count); > > +int f2fs_do_shutdown(struct f2fs_sb_info *sbi, unsigned int flag, > > + bool readonly); > > int f2fs_precache_extents(struct inode *inode); > > int f2fs_fileattr_get(struct dentry *dentry, struct fileattr *fa); > > int f2fs_fileattr_set(struct mnt_idmap *idmap, > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index 4ca6c693b33a..d223175b3d5c 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -2226,34 +2226,13 @@ static int f2fs_ioc_abort_atomic_write(struct file *filp) > > return ret; > > } > > -static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) > > +int f2fs_do_shutdown(struct f2fs_sb_info *sbi, unsigned int flag, > > + bool readonly) > > { > > - struct inode *inode = file_inode(filp); > > - struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > > struct super_block *sb = sbi->sb; > > - __u32 in; > > int ret = 0; > > - if (!capable(CAP_SYS_ADMIN)) > > - return -EPERM; > > - > > - if (get_user(in, (__u32 __user *)arg)) > > - return -EFAULT; > > - > > - if (in != F2FS_GOING_DOWN_FULLSYNC) { > > - ret = mnt_want_write_file(filp); > > - if (ret) { > > - if (ret == -EROFS) { > > - ret = 0; > > - f2fs_stop_checkpoint(sbi, false, > > - STOP_CP_REASON_SHUTDOWN); > > - trace_f2fs_shutdown(sbi, in, ret); > > - } > > - return ret; > > - } > > - } > > - > > - switch (in) { > > + switch (flag) { > > case F2FS_GOING_DOWN_FULLSYNC: > > ret = bdev_freeze(sb->s_bdev); > > if (ret) > > @@ -2292,6 +2271,9 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) > > goto out; > > } > > + if (readonly) > > + goto out; > > + > > f2fs_stop_gc_thread(sbi); > > f2fs_stop_discard_thread(sbi); > > @@ -2300,10 +2282,44 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) > > f2fs_update_time(sbi, REQ_TIME); > > out: > > - if (in != F2FS_GOING_DOWN_FULLSYNC) > > - mnt_drop_write_file(filp); > > - trace_f2fs_shutdown(sbi, in, ret); > > + trace_f2fs_shutdown(sbi, flag, ret); > > + > > + return ret; > > +} > > + > > +static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) > > +{ > > + struct inode *inode = file_inode(filp); > > + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > > + __u32 in; > > + int ret; > > + bool need_drop = false, readonly = false; > > + > > + if (!capable(CAP_SYS_ADMIN)) > > + return -EPERM; > > + > > + if (get_user(in, (__u32 __user *)arg)) > > + return -EFAULT; > > + > > + if (in != F2FS_GOING_DOWN_FULLSYNC) { > > + ret = mnt_want_write_file(filp); > > + if (ret) { > > + if (ret != -EROFS) > > + return ret; > > + > > + /* fallback to nosync shutdown for readonly fs */ > > + in = F2FS_GOING_DOWN_NOSYNC; > > + readonly = true; > > + } else { > > + need_drop = true; > > + } > > + } > > + > > + ret = f2fs_do_shutdown(sbi, in, readonly); > > + > > + if (need_drop) > > + mnt_drop_write_file(filp); > > return ret; > > } > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > > index 78a76583a4aa..0676c2dcbbf7 100644 > > --- a/fs/f2fs/super.c > > +++ b/fs/f2fs/super.c > > @@ -2547,6 +2547,11 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) > > return err; > > } > > +static void f2fs_shutdown(struct super_block *sb) > > +{ > > + f2fs_do_shutdown(F2FS_SB(sb), F2FS_GOING_DOWN_NOSYNC, false); > > +} > > + > > #ifdef CONFIG_QUOTA > > static bool f2fs_need_recovery(struct f2fs_sb_info *sbi) > > { > > @@ -3146,6 +3151,7 @@ static const struct super_operations f2fs_sops = { > > .unfreeze_fs = f2fs_unfreeze, > > .statfs = f2fs_statfs, > > .remount_fs = f2fs_remount, > > + .shutdown = f2fs_shutdown, > > }; > > #ifdef CONFIG_FS_ENCRYPTION