Re: [PATCH v2 5/6] iio: pressure: Add timestamp and scan_masks for BMP280 driver

Vasileios Amoiridis
2024-03-13T19:56:03Z

On Wed, Mar 13, 2024 at 08:54:47PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 13, 2024 at 06:40:06PM +0100, Vasileios Amoiridis wrote:
> > The scan mask for the BME280 supports humidity measurement needs
> > to be distinguished from the rest in order for the timestamp to
> > be able to work. Scan masks are added for different combinations
> > of measurements. The temperature measurement is always needed for
> > pressure and humidity measurements.
>
> (Just to make sure if you used --histogram diff algo when preparing the series)
>
> ...
>
> > {
> > - .type = IIO_HUMIDITYRELATIVE,
> > + .type = IIO_PRESSURE,
> > .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) |
> > BIT(IIO_CHAN_INFO_RAW) |
> > BIT(IIO_CHAN_INFO_SCALE) |
> > BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> > - .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> > + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) |
>
> Stray change
>
I didn't notice that, and the checkpatch.pl didn't actually say something,
thanks for pointing out.
> > BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY),
> > + .scan_index = 1,
> > + .scan_type = {
> > + .sign = 'u',
> > + .realbits = 32,
> > + .storagebits = 32,
> > + .endianness = IIO_CPU,
> > + },
> > },
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Best regards,
Vasilis Amoiridis