Re: [PATCH v2 6/6] iio: pressure: Add triggered buffer support for BMP280 driver

Vasileios Amoiridis
2024-03-13T20:00:35Z

On Wed, Mar 13, 2024 at 08:58:07PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 13, 2024 at 06:40:07PM +0100, Vasileios Amoiridis wrote:
> > Add a buffer struct that will hold the values of the measurements
> > and will be pushed to userspace and a buffer_handler function to
> > read the data and push them.
>
> ...
>
> > + ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
>
> dev here
>
> > + iio_pollfunc_store_time,
> > + &bmp280_buffer_handler, NULL);
> > + if (ret)
> > + return dev_err_probe(data->dev, ret,
>
> data->dev here
>
> Are they the same? If not, why this difference?
>
They are the same. I didn't notice it, but I will fix it for consistency.

> > + "iio triggered buffer setup failed\n");
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Best regards,
Vasileios Amoiridis