Re: [PATCH v3 3/6] iio: pressure: add SCALE and RAW values for channels

Andy Shevchenko
2024-03-13T20:04:12Z

On Wed, Mar 13, 2024 at 08:51:10PM +0100, Vasileios Amoiridis wrote:
> On Wed, Mar 13, 2024 at 09:03:08PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 13, 2024 at 06:40:04PM +0100, Vasileios Amoiridis wrote:
> > > Add extra IIO_CHAN_INFO_SCALE and IIO_CHAN_INFO_RAW in order to be
> > > able to calculate the processed value with standard userspace IIO
> > > tools. Can be used for triggered buffers as well.

...

> > > + case IIO_CHAN_INFO_RAW:
> > > + switch (chan->type) {
> > > + case IIO_HUMIDITYRELATIVE:
> > > + *val = data->chip_info->read_humid(data);
> > > + ret = IIO_VAL_INT;
> > > + break;
> > > + case IIO_PRESSURE:
> > > + *val = data->chip_info->read_press(data);
> > > + ret = IIO_VAL_INT;
> > > + break;
> > > + case IIO_TEMP:
> > > + *val = data->chip_info->read_temp(data);
> > > + ret = IIO_VAL_INT;
> > > + break;
> > > + default:
> > > + ret = -EINVAL;
> > > + break;
> >
> > Is it mutex that prevents us from returning here?
> > If so, perhaps switching to use cleanup.h first?
>
> I haven't seen cleanup.h used in any file and now that I searched,
> only 5-6 are including it.

Hmm... Which repository you are checking with?

$ git grep -lw cleanup.h -- drivers/ | wc -l
47

(Today's Linux Next)

> I am currently thinking if the mutex
> that already exists is really needed since most of the drivers
> don't have it + I feel like this is something that should be done
> by IIO, thus maybe it's not even needed here.

> > > + }
> > > + break;

--
With Best Regards,
Andy Shevchenko