From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ai Chao <aichao@kylinos.cn>
Cc: bleung@chromium.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform/chrome: use sysfs_emit() instead of sprintf()
Date: Thu, 14 Mar 2024 16:35:02 +0800 [thread overview]
Message-ID: <ZfK2tmJ3c1Td2lVR@google.com> (raw)
In-Reply-To: <20240314052828.186924-1-aichao@kylinos.cn>
On Thu, Mar 14, 2024 at 01:28:28PM +0800, Ai Chao wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
It seems we overlooked the case when handling [1]. Will queue the patch
after for-next rebased to next -rc1.
[1] https://patchwork.kernel.org/project/chrome-platform/patch/202212021656040995199@zte.com.cn/
next prev parent reply other threads:[~2024-03-14 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 5:28 [PATCH v1] platform/chrome: use sysfs_emit() instead of sprintf() Ai Chao
2024-03-14 8:35 ` Tzung-Bi Shih [this message]
2024-03-25 2:40 ` patchwork-bot+chrome-platform
2024-03-25 2:40 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfK2tmJ3c1Td2lVR@google.com \
--to=tzungbi@kernel.org \
--cc=aichao@kylinos.cn \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).