Re: [PATCH 5.10 00/73] 5.10.213-rc1 review

Pavel Machek
2024-03-22T13:35:40Z

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

Hi!

> > > > > Marek Vasut (1):
> > > > > regmap: Add bulk read/write callbacks into regmap_config
> > > >
> > > > This one quite intrusive for the stable. Plus, at least "regmap: Add
> > > > missing map->bus check" is marked as fixing this one.
> > >
> > > If there is no very good reason to include that regmap patch in stable
> > > backports, I would skip it, it is a feature patch. Does any backport depend
> > > on it ?
> >
> > Well, yes and no.
> >
> > Series of max310x patches depends on it:
> >
> > !!a just a preparation; buggy, whole series for fixing this |ef8537927 285e76 o: 5.10| serial: max
> > 310x: use regmap methods for SPI batch operations
> >
> > ...
> >
> > !! whole series to fix corruption, which did not exist in 5.10 in the first place |57871c388 3f42b1 o: 5.10| serial: max310x: fix IO data corruption in batched
> > operations
> >
> > But according to the 3f42b1, the bug did not exist in 5.10 in the
> > first place, so we got buggy 285e76 backported, and then fixes up-to
> > 3f42b1 applied to fix it up.
>
> Then probably both max30x patches should be dropped/reverted and the regmap
> bulk callbacks also dropped ?

Agreed.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]