From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Mukesh Ojha <quic_mojha@quicinc.com>,
rostedt@goodmis.org, senozhatsky@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Update @console_may_schedule in console_trylock_spinning()
Date: Fri, 15 Mar 2024 17:10:35 +0100 [thread overview]
Message-ID: <ZfRy3hsv_m9kNhpR@alley> (raw)
In-Reply-To: <875xybmo2z.fsf@jogness.linutronix.de>
On Mon 2024-02-26 13:07:24, John Ogness wrote:
> console_trylock_spinning() may takeover the console lock from a
> schedulable context. Update @console_may_schedule to make sure it
> reflects a trylock acquire.
>
> Reported-by: Mukesh Ojha <quic_mojha@quicinc.com>
> Link: https://lore.kernel.org/lkml/20240222090538.23017-1-quic_mojha@quicinc.com
> Fixes: dbdda842fe96 ("printk: Add console owner and waiter logic to load balance console writes")
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Makes perfect sense:
Reviewed-by: Petr Mladek <pmladek@suse.com>
JFYI, the patch has been committed into printk/linux.git, for-6.9
branch.
I am going to give it a spin in for-next and get it into 6.9
either in the 2nd half of the merge window or in rc1.
Best Regards,
Petr
prev parent reply other threads:[~2024-03-15 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 9:05 [PATCH] printk: Add atomic context check inside console_unlock() Mukesh Ojha
2024-02-22 14:53 ` John Ogness
2024-02-26 10:17 ` Mukesh Ojha
2024-02-26 12:01 ` [PATCH] printk: Update @console_may_schedule in console_trylock_spinning() John Ogness
2024-02-26 12:17 ` Mukesh Ojha
2024-02-26 13:02 ` John Ogness
2024-02-27 16:37 ` Mukesh Ojha
2024-03-15 16:10 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfRy3hsv_m9kNhpR@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox