From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, ang.iglesiasg@gmail.com,
mazziesaccount@gmail.com, ak@it-klinger.de,
petre.rodan@subdimension.ro, phil@raspberrypi.com,
579lpy@gmail.com, linus.walleij@linaro.org,
semen.protsenko@linaro.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/6] iio: pressure: Add triggered buffer support for BMP280 driver
Date: Wed, 20 Mar 2024 23:25:46 +0200 [thread overview]
Message-ID: <ZftUWg31QvA99syr@smile.fi.intel.com> (raw)
In-Reply-To: <20240320174602.GA36450@vamoiridPC>
On Wed, Mar 20, 2024 at 06:46:02PM +0100, Vasileios Amoiridis wrote:
> On Wed, Mar 20, 2024 at 01:16:03PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 19, 2024 at 01:29:25AM +0100, Vasileios Amoiridis wrote:
...
> > > /*
> > > - * Maximum number of consecutive bytes read for a temperature or
> > > - * pressure measurement is 3.
> > > + * Maximum number of a burst read for temperature, pressure, humidity
> > > + * is 8 bytes.
> > > */
> > > - if (val_size > 3)
> > > + if (val_size > 8)
> >
> > sizeof() / new definition for the buf[] size?
>
> In a previous commit that I was fixing this SPI driver, Jonathan had mentioned
> that there is no need for a specific definition since it will only be used
> here so that's why I kept it as is.
It seems not only here, but also in the buf[] definition in the struct.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-20 21:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 0:29 [PATCH v3 0/6] Series to add triggered buffer support to BMP280 driver Vasileios Amoiridis
2024-03-19 0:29 ` [PATCH v3 1/6] iio: pressure: BMP280 core driver headers sorting Vasileios Amoiridis
2024-03-20 11:00 ` Andy Shevchenko
2024-03-24 11:14 ` Jonathan Cameron
2024-03-19 0:29 ` [PATCH v3 2/6] iio: pressure: Introduce new cleanup routines to BMP280 driver *_raw() functions Vasileios Amoiridis
2024-03-20 11:00 ` Andy Shevchenko
2024-03-20 11:04 ` Andy Shevchenko
2024-03-24 11:20 ` Jonathan Cameron
2024-03-19 0:29 ` [PATCH v3 3/6] iio: pressure: Generalize read_{temp/press/humid}() functions Vasileios Amoiridis
2024-03-20 11:04 ` Andy Shevchenko
2024-03-24 11:36 ` Jonathan Cameron
2024-04-02 17:55 ` Vasileios Amoiridis
2024-04-06 10:02 ` Jonathan Cameron
2024-03-19 0:29 ` [PATCH v3 4/6] iio: pressure: Add SCALE and RAW values for channels Vasileios Amoiridis
2024-03-20 11:05 ` Andy Shevchenko
2024-03-19 0:29 ` [PATCH v3 5/6] iio: pressure: Add timestamp and scan_masks for BMP280 driver Vasileios Amoiridis
2024-03-20 11:07 ` Andy Shevchenko
2024-03-20 18:45 ` Vasileios Amoiridis
2024-03-20 20:38 ` Andy Shevchenko
2024-03-20 21:31 ` Vasileios Amoiridis
2024-03-21 11:22 ` Andy Shevchenko
2024-03-24 11:43 ` Jonathan Cameron
2024-03-19 0:29 ` [PATCH v3 6/6] iio: pressure: Add triggered buffer support " Vasileios Amoiridis
2024-03-20 11:16 ` Andy Shevchenko
2024-03-20 17:46 ` Vasileios Amoiridis
2024-03-20 21:25 ` Andy Shevchenko [this message]
2024-03-20 21:35 ` Vasileios Amoiridis
2024-03-24 11:55 ` Jonathan Cameron
2024-03-24 12:14 ` Jonathan Cameron
2024-04-02 18:08 ` Vasileios Amoiridis
2024-04-06 10:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZftUWg31QvA99syr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=579lpy@gmail.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
--cc=phil@raspberrypi.com \
--cc=semen.protsenko@linaro.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox