Re: [PATCH 1/2] x86/microcode/AMD: Add a patch revision number union

Ingo Molnar
2024-03-21T19:25:04Z

* Borislav Petkov <bp@alien8.de> wrote:

> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> Add a structure which will be used to split the Zen generation of
> microcode revision numbers into its corresponding elements. This will be
> used to match microcode patches a lot easier and obviate the need for
> a equivalence table.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: John Allen <john.allen@amd.com>
> ---
> arch/x86/include/asm/microcode.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/x86/include/asm/microcode.h b/arch/x86/include/asm/microcode.h
> index 695e569159c1..c1de0a6aefbc 100644
> --- a/arch/x86/include/asm/microcode.h
> +++ b/arch/x86/include/asm/microcode.h
> @@ -47,6 +47,18 @@ struct microcode_intel {
> unsigned int bits[];
> };
>
> +union zen_patch_rev {
> + struct {
> + __u32 rev : 8,
> + stepping : 4,
> + model : 4,
> + __resv : 4,
> + ext_model : 4,
> + ext_fam : 8;
> + };
> + __u32 ucode_rev;
> +};

s/__resv/__reserved please?

Had to look twice (ok, I'm lying, had to look 3 times) whether it stood for
'reserved' or some source of 'revision' / 'reservation' thing.

Thanks,

Ingo