From: Mike Snitzer <snitzer@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: ming.lei@redhat.com, hch@lst.de, bvanassche@acm.org,
axboe@kernel.dk, mpatocka@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 2/2] block: remove blk_mq_in_flight() and blk_mq_in_flight_rw()
Date: Sun, 24 Mar 2024 17:57:30 -0400 [thread overview]
Message-ID: <ZgChym1BEpxUm_bL@redhat.com> (raw)
In-Reply-To: <abb0af09-e9bb-4781-176b-b4b98726c211@huaweicloud.com>
On Sat, Mar 23 2024 at 10:11P -0400,
Yu Kuai <yukuai1@huaweicloud.com> wrote:
> Hi,
>
> 在 2024/03/24 0:05, Mike Snitzer 写道:
> > On Fri, Mar 22 2024 at 11:59P -0400,
> > Yu Kuai <yukuai1@huaweicloud.com> wrote:
> >
> > > From: Yu Kuai <yukuai3@huawei.com>
> > >
> > > Now that blk-mq also use per_cpu counter to trace inflight as bio-based
> > > device, they can be replaced by part_in_flight() and part_in_flight_rw()
> > > directly.
> >
> > Please reference the commit that enabled this, e.g.:
> >
> > With commit XXXXX ("commit subject") blk-mq was updated to use per_cpu
> > counters to track inflight IO same as bio-based devices, so replace
> > blk_mq_in_flight* with part_in_flight() and part_in_flight_rw()
> > accordingly.
>
> Patch 1 in this set do this, so there is no commit xxx yet.
>
> Thanks,
> Kuai
Would've helped if I looked at 1/2, but please say:
With the previous commit blk-mq was updated to use per_cpu ...
next prev parent reply other threads:[~2024-03-24 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 3:59 [PATCH 0/2] block: support to account io_ticks precisely Yu Kuai
2024-03-23 3:59 ` [PATCH 1/2] " Yu Kuai
2024-03-23 3:59 ` [PATCH 2/2] block: remove blk_mq_in_flight() and blk_mq_in_flight_rw() Yu Kuai
2024-03-23 16:05 ` Mike Snitzer
2024-03-24 2:11 ` Yu Kuai
2024-03-24 21:57 ` Mike Snitzer [this message]
2024-03-25 1:15 ` Yu Kuai
2024-03-23 3:59 ` [PATCH 0/2] block: support to account io_ticks precisely Yu Kuai
2024-03-23 4:08 ` Yu Kuai
2024-03-23 3:59 ` [PATCH 1/2] " Yu Kuai
2024-03-23 3:59 ` [PATCH 2/2] block: remove blk_mq_in_flight() and blk_mq_in_flight_rw() Yu Kuai
2024-04-06 7:57 ` [PATCH 0/2] block: support to account io_ticks precisely Yu Kuai
2024-04-20 1:49 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgChym1BEpxUm_bL@redhat.com \
--to=snitzer@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox