From: Wei Liu <wei.liu@kernel.org>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: Wei Liu <wei.liu@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: Re: [PATCH] hv: vmbus: Convert sprintf() family to sysfs_emit() family
Date: Mon, 25 Mar 2024 17:49:47 +0000 [thread overview]
Message-ID: <ZgG5O3uO9JgOmU_Q@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <5c1f6aba-bd3c-438c-8e00-548fe29d8136@fujitsu.com>
On Mon, Mar 25, 2024 at 09:39:52AM +0000, Zhijian Li (Fujitsu) wrote:
>
>
> On 23/03/2024 07:37, Wei Liu wrote:
> > Hi Zhijian,
> >
> > On Tue, Mar 19, 2024 at 11:43:50AM +0800, Li Zhijian wrote:
> >> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> >> or sysfs_emit_at() when formatting the value to be returned to user space.
> >>
> >> coccinelle complains that there are still a couple of functions that use
> >> snprintf(). Convert them to sysfs_emit().
> >>
> >> sprintf() and scnprintf() will be converted as well if they have.
> >
> > This sentence seems to have been cut off halfway. If they have what?
>
> Is it hard to understand, what I want to say is:
>
> Sprintf() and scnprintf() will be converted if these files have such abused cases.
>
> Shall I update it and send a V2?
No need. I can fix up the commit message when I apply the patch. Thanks.
>
> Thanks
> Zhijian
>
>
>
> >
> > The code looks fine.
> >
> > Thanks,
> > Wei.
next prev parent reply other threads:[~2024-03-25 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 3:43 [PATCH] hv: vmbus: Convert sprintf() family to sysfs_emit() family Li Zhijian
2024-03-22 23:37 ` Wei Liu
2024-03-25 9:39 ` Zhijian Li (Fujitsu)
2024-03-25 17:49 ` Wei Liu [this message]
2024-04-10 21:25 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgG5O3uO9JgOmU_Q@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox