Re: [PATCH v3 00/12] mm/gup: Unify hugetlb, part 2

Peter Xu
2024-04-05T21:42:52Z

On Fri, Apr 05, 2024 at 03:16:33PM -0300, Jason Gunthorpe wrote:
> On Thu, Apr 04, 2024 at 05:48:03PM -0400, Peter Xu wrote:
> > On Tue, Mar 26, 2024 at 11:02:52AM -0300, Jason Gunthorpe wrote:
> > > The more I look at this the more I think we need to get to Matthew's
> > > idea of having some kind of generic page table API that is not tightly
> > > tied to level. Replacing the hugetlb trick of 'everything is a PTE'
> > > with 5 special cases in every place seems just horrible.
> > >
> > > struct mm_walk_ops {
> > > int (*leaf_entry)(struct mm_walk_state *state, struct mm_walk *walk);
> > > }
> > >
> > > And many cases really want something like:
> > > struct mm_walk_state state;
> > >
> > > if (!mm_walk_seek_leaf(state, mm, address))
> > > goto no_present
> > > if (mm_walk_is_write(state)) ..
> > >
> > > And detailed walking:
> > > for_each_pt_leaf(state, mm, address) {
> > > if (mm_walk_is_write(state)) ..
> > > }
> > >
> > > Replacing it with a mm_walk_state that retains the level or otherwise
> > > to allow decoding any entry composes a lot better. Forced Loop
> > > unrolling can get back to the current code gen in alot of places.
> > >
> > > It also makes the power stuff a bit nicer as the mm_walk_state could
> > > automatically retain back pointers to the higher levels in the state
> > > struct too...
> > >
> > > The puzzle is how to do it and still get reasonable efficient codegen,
> > > many operations are going to end up switching on some state->level to
> > > know how to decode the entry.
> >
> > These discussions are definitely constructive, thanks Jason. Very helpful.
> >
> > I thought about this last week but got interrupted. It does make sense to
> > me; it looks pretty generic and it is flexible enough as a top design. At
> > least that's what I thought.
>
> Yeah, exactly..
>
> > However now when I rethink about it, and look more into the code when I got
> > the chance, it turns out this will be a major rewrite of mostly every
> > walkers..
>
> Indeed, it is why it may not be reasonable.
>
> > Consider that what we (or.. I) want to teach the pXd layers are two things
> > right now: (1) hugetlb mappings (2) MMIO (PFN) mappings. That mostly
> > shares the generic concept when working on the mm walkers no matter which
> > way to go, just different treatment on different type of mem. (2) is on
> > top of current code and new stuff, while (1) is a refactoring to drop
> > hugetlb_entry() hook point as the goal.
>
> Right, I view this as a two pronged attack
>
> One one front you teach the generic pXX_* macros to process huge pages
> and push that around to the performance walkers like GUP
>
> On another front you want to replace use of the hugepte with the new
> walkers.
>
> The challenge with the hugepte code is that it is all structured to
> assume one API that works at all levels and that may be a hard fit to
> replace with pXX_* functions.

That's the core of problem, or otherwise I feel like I might be doing
something else already. I had a feeling even if it's currently efficient
for hugetlb, we'll drop that sooner or later.

The issue is at least hugetlb pgtable format is exactly the same as the
rest, as large folio grows it will reach the point that we complain more
than before on having hugetlb does its smart things on its own.

>
> The places that are easy to switch from hugetlb to pXX_* may as well
> do so.
>
> Other places maybe need a hugetlb replacement that has a similar
> abstraction level of pointing to any page table level.

IMHO this depends.

Per my current knowledge, hugetlb is only special in three forms:

- huge mapping (well, this isn't that special..)
- cont pte/pmd/...
- hugepd

The most fancy one is actually hugepd.. but I plan to put that temporarily
aside - I haven't look at Christophe's series yet, however I think we're
going to solve orthogonal issues but his work will definitely help me on
reaching mine, and I want to think through first on my end of things to
know a plan. If hugepd has its chance to be generalized, the worst case is
I'll leverage CONFIG_ARCH_HAS_HUGEPD and only keep hugetlb_entry() for them
until hugepd became some cont-pxx variance. Then when I put HAS_HUGEPD
aside, I don't think it's very complicated, perhaps?

In short, hugetlb mappings shouldn't be special comparing to other huge pXd
and large folio (cont-pXd) mappings for most of the walkers in my mind, if
not all. I need to look at all the walkers and there can be some tricky
ones, but I believe that applies in general. It's actually similar to what
I did with slow gup here.

Like this series, for cont-pXd we'll need multiple walks comparing to
before (when with hugetlb_entry()), but for that part I'll provide some
performance tests too, and we also have a fallback plan, which is to detect
cont-pXd existance, which will also work for large folios.

>
> I think if you do the easy places for pXX conversion you will have a
> good idea about what is needed for the hard places.

Here IMHO we don't need to understand "what is the size of this hugetlb
vma", or "which level of pgtable does this hugetlb vma pages locate",
because we may not need that, e.g., when we only want to collect some smaps
statistics. "whether it's hugetlb" may matter, though. E.g. in the mm
walker we see a huge pmd, it can be a thp, it can be a hugetlb (when
hugetlb_entry removed), we may need extra check later to put things into
the right bucket, but for the walker itself it doesn't necessarily need
hugetlb_entry().

>
> > Now the important question I'm asking myself is: do we really need huge p4d
> > or even bigger?
>
> Do we need huge p4d support with folios? Probably not..
>
> huge p4d support for pfnmap, eg in VFIO. Yes I think that is possibly
> interesting - but I wouldn't ask anyone to do the work :)

Considering it does not yet exist, and we don't have plan to work it out
(so far), maybe I can see this as a very implicit ack that I can put that
aside at least of now. :)

>
> But then again we come back to power and its big list of page sizes
> and variety :( Looks like some there have huge sizes at the pgd level
> at least.

Yeah this is something I want to be super clear, because I may miss
something: we don't have real pgd pages, right? Powerpc doesn't even
define p4d_leaf(), AFAICT.

$ git grep p4d_leaf
arch/powerpc/mm/book3s64/radix_pgtable.c: if (p4d_leaf(*p4d)) {
arch/powerpc/mm/pgtable.c: if (p4d_leaf(p4d)) {
arch/powerpc/mm/pgtable_64.c: if (p4d_leaf(p4d)) {
arch/powerpc/mm/pgtable_64.c: VM_WARN_ON(!p4d_leaf(p4d));
arch/powerpc/xmon/xmon.c: if (p4d_leaf(*p4dp)) {

They all constantly return false (which is the fallback)?

>
> > So, can we over-engineer too much if we go the generic route now?
>
> Yes we can, and it will probably be slow as well. The pXX macros are
> the most efficient if code can be adapted to use them.
>
> > Considering that we already have most of pmd/pud entries around in the mm
> > walker ops.
>
> Yeah, so you add pgd and maybe p4d and then we can don't need any
> generic thing. If it is easy it would be nice.

I want to double check on above on PowerPC first, otherwise I'd consider
leaving p4d+ alone, if that looks ok. It could be that I missed something
important, Christophe may want to chim in if he has any thoughts or just to
clarify my mistakes.

Thanks,

--
Peter Xu