From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sudan Landge <sudanl@amazon.com>,
tytso@mit.edu, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com,
thomas.lendacky@amd.com, dan.j.williams@intel.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
graf@amazon.de, dwmw@amazon.co.uk, bchalios@amazon.es,
xmarcalx@amazon.co.uk
Subject: Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
Date: Tue, 26 Mar 2024 15:10:11 +0100 [thread overview]
Message-ID: <ZgLXQ0P8aDl4Xh21@zx2c4.com> (raw)
In-Reply-To: <5ca78fc8-4a53-4f09-878f-4a47875f9de5@linaro.org>
On Mon, Mar 25, 2024 at 10:51:25PM +0100, Krzysztof Kozlowski wrote:
> > .owner = THIS_MODULE,
>
> This is clearly some abandoned driver... sigh... I thought we get rid of
> all this owner crap. Many years ago. How could it appear back if
> automated tools report it?
>
> Considering how many failures LKP reported for your patchsets, I have
> real doubts that anyone actually tests this code.
Now you're commenting on the context rather than the patch.
No, this isn't an abandoned driver, no it's not untested. Rather, it's
code I maintain, care deeply about, and have a tree that receives quite
a bit of testing (random.git) where I'll be taking these OF patches in
the case that this patchset improves (and thanks very much for your
review on it; I'll be appreciative of your ack whenever/if ever it
improves to that point), and if you have other cleanups like removing
.owner, please don't hesitate to send a patch.
That all is to say, I'm following these threads closely and care.
Jason
next prev parent reply other threads:[~2024-03-26 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 19:53 [PATCH v3 0/4] virt: vmgenid: Add devicetree bindings support Sudan Landge
2024-03-25 19:53 ` [PATCH v3 1/4] virt: vmgenid: rearrange code to make review easier Sudan Landge
2024-03-25 19:53 ` [PATCH v3 2/4] virt: vmgenid: change implementation to use a platform driver Sudan Landge
2024-03-25 21:54 ` Krzysztof Kozlowski
2024-03-25 19:53 ` [PATCH v3 3/4] dt-bindings: rng: Add vmgenid support Sudan Landge
2024-03-25 20:53 ` Rob Herring
2024-03-25 21:59 ` Krzysztof Kozlowski
2024-03-25 19:53 ` [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings Sudan Landge
2024-03-25 21:51 ` Krzysztof Kozlowski
2024-03-26 14:01 ` Landge, Sudan
2024-03-26 14:10 ` Jason A. Donenfeld [this message]
2024-03-26 16:56 ` Krzysztof Kozlowski
2024-03-26 12:48 ` kernel test robot
2024-03-26 12:53 ` Krzysztof Kozlowski
2024-03-26 14:05 ` Landge, Sudan
2024-03-26 15:24 ` kernel test robot
2024-03-26 16:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgLXQ0P8aDl4Xh21@zx2c4.com \
--to=jason@zx2c4.com \
--cc=bchalios@amazon.es \
--cc=conor+dt@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sudanl@amazon.com \
--cc=thomas.lendacky@amd.com \
--cc=tytso@mit.edu \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox