public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Landge, Sudan" <sudanl@amazon.co.uk>
Cc: Rob Herring <robh@kernel.org>, Sudan Landge <sudanl@amazon.com>,
	tytso@mit.edu, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com,
	thomas.lendacky@amd.com, dan.j.williams@intel.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	graf@amazon.de, dwmw@amazon.co.uk, bchalios@amazon.es,
	xmarcalx@amazon.co.uk
Subject: Re: [PATCH v2 3/4] dt-bindings: rng: Add vmgenid support
Date: Tue, 26 Mar 2024 15:43:55 +0100	[thread overview]
Message-ID: <ZgLfKwp6cSrX7knJ@zx2c4.com> (raw)
In-Reply-To: <96df7e5a-52df-4171-9cd6-78d088a7a1e2@amazon.co.uk>

On Tue, Mar 26, 2024 at 01:06:16PM +0000, Landge, Sudan wrote:
> >>> Does the spec say anything about endianness or access size? DT assumes
> >>> native endianness by default. We have properties to deal these, but
> >>> would be better to be explicit if that's defined already.
> >>>
> >> The spec doesn't mention anything about the endianness but, I have
> >> updated the description with some more data.
> > 
> > Then what does your driver assume? Microsoft may not have thought
> > about it because they don't care, but now you want to use DT so you
> > have to because it is frequently used on BE systems. If we define
> > something, then there's some hope. Otherwise, it's pretty much a
> > guarantee folks will do the opposite.
> > 
> > Rob
> The driver does not assume any endianness. To provide more context, The 
> hypervisor stores a 128bit unique ID at the address pointed by the 
> "reg"'s 1st cell, driver memcpy's this ID to an internal context and 
> uses memcmp to compare if the ID is new or old.
> But yes, it will be good to define a fixed endianness to avoid any 
> error. I will update the description to use little endian.

It's a 16-byte blob. Why care about endianness at all here? Treat it as
a byte string, not an integer.

Jason

  reply	other threads:[~2024-03-26 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21  2:51 [PATCH v2 0/4] virt: vmgenid: Add devicetree bindings support Sudan Landge
2024-03-21  2:51 ` [PATCH v2 1/4] virt: vmgenid: rearrange code to make review easier Sudan Landge
2024-03-21  2:51 ` [PATCH v2 2/4] virt: vmgenid: change implementation to use a platform driver Sudan Landge
2024-03-21  2:51 ` [PATCH v2 3/4] dt-bindings: rng: Add vmgenid support Sudan Landge
2024-03-25 15:06   ` Rob Herring
2024-03-25 20:11     ` Landge, Sudan
2024-03-25 20:41       ` Rob Herring
2024-03-26 13:06         ` Landge, Sudan
2024-03-26 14:43           ` Jason A. Donenfeld [this message]
2024-03-21  2:51 ` [PATCH v2 4/4] virt: vmgenid: add support for devicetree bindings Sudan Landge
2024-03-21 19:52   ` kernel test robot
2024-03-22  8:02   ` kernel test robot
2024-03-22 13:33   ` Rob Herring
2024-03-22 17:02     ` Landge, Sudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgLfKwp6cSrX7knJ@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=bchalios@amazon.es \
    --cc=conor+dt@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=graf@amazon.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=sudanl@amazon.co.uk \
    --cc=sudanl@amazon.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tytso@mit.edu \
    --cc=xmarcalx@amazon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox