From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8D7945C06 for ; Tue, 26 Mar 2024 17:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711474498; cv=none; b=YkCfpp6PtetrmFeOPEhyexZ6vfNuNQ1Pwc5hnVBy1G0vXfegzXxfjMTWEbkEq4cncLtAwcaLLX83hsGcTlfjBA2xj4lbcBSRqJQO5uGOHibJ9EdSrbD+j3vy3EMTXU+fqhv67V98oahRtQCaFpeysRpJRAiejTaOoXd2obOBpxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711474498; c=relaxed/simple; bh=lbl6QaHxe02Juccz6/C5e5ITu/8bnnT80pBEiwtkFv4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h77u60DQEM+Xuwv/BLxMVz0GgoxD2ImvcdXmXXC85ZvCCMJvcetLoYc7HzUacZRUSo0VuxbcJEBPwdypP9Dkelz06z4sWVA7Gyu4qX0rjouEjztn7Uv/TSmLBi53aoq0XMabfaAAIcMCxkjZ2nb38rAW9Uu3stHKd7J6sqlg5qY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91814C433C7; Tue, 26 Mar 2024 17:34:57 +0000 (UTC) Date: Tue, 26 Mar 2024 17:34:55 +0000 From: Catalin Marinas To: Waiman Long Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/kmemleak: Disable KASAN instrumentation in kmemleak Message-ID: References: <20240307190548.963626-1-longman@redhat.com> <20240307190548.963626-3-longman@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240307190548.963626-3-longman@redhat.com> On Thu, Mar 07, 2024 at 02:05:48PM -0500, Waiman Long wrote: > Kmemleak ia a memory leak checker. KASAN is also a memory checker but > it focuses more on finding out-of-bounds and use-after-free bugs. Since > kmemleak is inherently slow especially on systems with large number of > CPUs, adding KASAN instrumentation will make it slower even more. As > kmemleak is not for production use, the utility of enabling KASAN there > is questionable. > > This patch disables KASAN instrumentation for configurations that > enable both of them to slightly reduce performance overhead. > > Signed-off-by: Waiman Long Acked-by: Catalin Marinas