Re: [PATCH v1 07/10] spi: pxa2xx: Provide num-cs for Sharp PDAs via device properties

Mark Brown
2024-03-26T18:21:53Z

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Tue, Mar 26, 2024 at 08:07:57PM +0200, Andy Shevchenko wrote:

> Since driver can parse num-cs device property, replace platform data
> with this new approach.

But why?

> -static struct pxa2xx_spi_controller spitz_spi_info = {
> - .num_chipselect = 3,
> -};

> +static const struct property_entry spitz_spi_properties[] = {
> + PROPERTY_ENTRY_U32("num-cs", 3),
> + { }
> +};

This is just platform data with less validation AFAICT.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]