From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D666380; Tue, 26 Mar 2024 19:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711480812; cv=none; b=sgnaOr3wlv/NCP/VcCMQz611Gdy0l4Ik8iyCbXVEZhIEYXot7FN4Iz5ijPhdZAmHWxlfPPsmkCgQ33cnk5rNkSxr8TrJluy+FeFw2KQ3BtjoraNtnJKajgEzYy1TUcwp7azgevEICi6cCSSQXHk2x+V4TTfVRbn+k2pFueJ4iuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711480812; c=relaxed/simple; bh=R7xbAsvSxB0RZwS8L7Atbz7U7DNt/7IiXhnlPgLQ2Cs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eoUMtVW6Gws9cCsJl2Kj9LzYw1WeDiQuhfe1EhNY2NhsUTO/klnahOcsko4EAWmDp75ObZVWEtK61I2sYcM2DrlISsKf/lanc8MWjsm21rOq0QtGogSE/hEH/pG7nJYVsAGTw2dfC2BccbxOwq37sEptKKNrs+jgAKwE83kBRgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QpiBepEM; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QpiBepEM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711480811; x=1743016811; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=R7xbAsvSxB0RZwS8L7Atbz7U7DNt/7IiXhnlPgLQ2Cs=; b=QpiBepEMDQqsFJ7DPz9DTlM0YmBqZqhE+y2pl9NIgdg/sWwY8dRduSVN 1NVy1qlzNJMSVhGc4toztaGMLfAZ6gc2doZwiwsUGkghj/pdzJWuBO7Hf ypFtp8VXfcwDeHENT6sI3hANSZGpc9rGtpq3f134kCAij3A9mDC10cNrV xRJOw6ZiFgHmG+5r8JfDfj9gSGRPmdntjZgTbmcrry9VJHLnR0swCk0jf 2kMhhkecItmtmJWXGt6JJN6IUT5V/HKsQz6/hjmbpu6a7bLIlNnW89y+4 STK2t+AfouHMn5XOLU7wjDqL7F4R5aVKC7aBfp0sxkN5y/qjSRsmfMXku g==; X-CSE-ConnectionGUID: Or8I6vexRG6xWjfHXr7sYg== X-CSE-MsgGUID: tQgnjfdfQKmIKmkK1+G2XA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="29031052" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="29031052" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 12:20:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914888450" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914888450" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 12:20:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpCL7-0000000GQvL-2pWs; Tue, 26 Mar 2024 21:20:05 +0200 Date: Tue, 26 Mar 2024 21:20:05 +0200 From: Andy Shevchenko To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King Subject: Re: [PATCH v1 01/10] spi: pxa2xx: Drop ACPI_PTR() and of_match_ptr() Message-ID: References: <20240326181027.1418989-1-andriy.shevchenko@linux.intel.com> <20240326181027.1418989-2-andriy.shevchenko@linux.intel.com> <14f08a50-edef-4b36-891e-2b4b2283f40c@sirena.org.uk> <424de3ed-f0ea-4fc1-80f5-3ab1d23cf1e1@sirena.org.uk> <4241ecb8-07e4-4613-a289-4699c39d0d08@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4241ecb8-07e4-4613-a289-4699c39d0d08@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 26, 2024 at 07:10:09PM +0000, Mark Brown wrote: > On Tue, Mar 26, 2024 at 08:52:53PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 26, 2024 at 06:49:58PM +0000, Mark Brown wrote: > > > > > > > > I think the ACPI dependency there is as much about hiding the device on > > > > > > > irrelevant platforms as anything else, might be better replaced with an > > > > > > > x86 dependency though. > > > Oh, oh, my bad I missed acpi_dev_uid_to_integer() call. > > Okay, with that in mind it's functional dependency for the ACPI-based > > platforms. Do you want to keep it untouched? > > That's not actually what I was thinking of (please read what I wrote > above, like I say I was thining about hiding things) but surely if that > was a reason to keep the dependency it'd need to be an actual ACPI > dependency rather than an ||? For my knowledge there is none of the ACPI-based platform where CONFIG_ACPI needs to be 'n' while having the real device (as per ACPI ID table) to be on. That's why I answered purely from the compilation point of view. Personally I see that dependency more confusing than hinting about anything. -- With Best Regards, Andy Shevchenko