From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] interconnect: qcom: qcm2290: Fix mas_snoc_bimc QoS port assignment
Date: Tue, 26 Mar 2024 21:16:14 +0100 [thread overview]
Message-ID: <ZgMs_xZVzWH5uK-v@gerhold.net> (raw)
In-Reply-To: <20240326-topic-rpm_icc_qos_cleanup-v1-2-357e736792be@linaro.org>
On Tue, Mar 26, 2024 at 08:42:33PM +0100, Konrad Dybcio wrote:
> The value was wrong, resulting in misprogramming of the hardware.
> Fix it.
>
> Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/interconnect/qcom/qcm2290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c
> index 96735800b13c..ba4cc08684d6 100644
> --- a/drivers/interconnect/qcom/qcm2290.c
> +++ b/drivers/interconnect/qcom/qcm2290.c
> @@ -164,7 +164,7 @@ static struct qcom_icc_node mas_snoc_bimc = {
> .name = "mas_snoc_bimc",
> .buswidth = 16,
> .qos.ap_owned = true,
> - .qos.qos_port = 2,
> + .qos.qos_port = 6,
> .qos.qos_mode = NOC_QOS_MODE_BYPASS,
> .mas_rpm_id = 164,
The mas_rpm_id is also wrong, I think it should be = 3. This looks
wrongly copy pasted from BIMC_NRT. The qos_port on the other hand was
copied from BIMC_RT. I wonder how that happened. :')
Thanks,
Stephan
next prev parent reply other threads:[~2024-03-26 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 19:42 [PATCH 0/4] Rework rpm-icc QoS settings Konrad Dybcio
2024-03-26 19:42 ` [PATCH 1/4] interconnect: qcom: sm6115: Unspaghettify SNoC QoS port numbering Konrad Dybcio
2024-03-26 20:13 ` Dmitry Baryshkov
2024-03-26 20:32 ` Konrad Dybcio
2024-03-26 19:42 ` [PATCH 2/4] interconnect: qcom: qcm2290: Fix mas_snoc_bimc QoS port assignment Konrad Dybcio
2024-03-26 20:16 ` Stephan Gerhold [this message]
2024-03-26 21:32 ` Konrad Dybcio
2024-03-26 19:42 ` [PATCH 3/4] interconnect: qcom: icc-rpm: Make simple functions return void Konrad Dybcio
2024-03-26 20:14 ` Dmitry Baryshkov
2024-05-08 1:57 ` Mike Tipton
2024-03-26 19:42 ` [PATCH 4/4] interconnect: qcom: icc-rpm: Remodel how QoS settings are stored Konrad Dybcio
2024-03-26 20:57 ` Stephan Gerhold
2024-03-26 21:12 ` Konrad Dybcio
2024-05-08 1:45 ` Mike Tipton
2024-06-18 14:27 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgMs_xZVzWH5uK-v@gerhold.net \
--to=stephan@gerhold.net \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox