From: John Watts <contact@jookia.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats
Date: Thu, 28 Mar 2024 13:21:21 +1100 [thread overview]
Message-ID: <ZgTUIWh8qXH_7oxQ@titan> (raw)
In-Reply-To: <23447395.6Emhk5qWAg@jernej-laptop>
On Wed, Mar 27, 2024 at 08:53:32PM +0100, Jernej Škrabec wrote:
> I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S
> variants that are supported by this driver. If you check A10, you'll see that
> it doesn't support S32.
>
> If you want to add support for S32, you'll have to add new quirk for each
> variant.
Yes, A10 doesn't support it. But it should error out in hw_params due to
get_sr not supporting 32-bit, no?
>
> Best regards,
> Jernej
John.
next prev parent reply other threads:[~2024-03-28 2:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 3:50 [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats John Watts
2024-03-27 19:53 ` Jernej Škrabec
2024-03-28 2:21 ` John Watts [this message]
2024-03-28 13:56 ` Mark Brown
2024-03-28 14:56 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgTUIWh8qXH_7oxQ@titan \
--to=contact@jookia.org \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox