Re: [PATCH] pinctrl: pinconf-generic: check error value EOPNOTSUPP

Linus Walleij
2024-04-04T11:45:03Z

On Mon, Apr 1, 2024 at 4:02 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:

> From: Peng Fan <peng.fan@nxp.com>
>
> The SCMI error value SCMI_ERR_SUPPORT maps to linux error value
> '-EOPNOTSUPP', so when dump configs, need check the error value
> EOPNOTSUPP, otherwise there will be log "ERROR READING CONFIG SETTING".
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
(...)
> ret = pin_config_get_for_pin(pctldev, pin, &config);
> /* These are legal errors */
> - if (ret == -EINVAL || ret == -ENOTSUPP)
> + if (ret == -EINVAL || ret == -ENOTSUPP || ret == -EOPNOTSUPP)

TBH it's a bit odd to call an in-kernel API such as pin_config_get_for_pin()
and get -EOPNOTSUPP back. But it's not like I care a lot, so patch applied.

Yours,
Linus Walleij