From: Uladzislau Rezki <urezki@gmail.com>
To: Hillf Danton <hdanton@sina.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
syzbot <syzbot+1fa663a2100308ab6eab@syzkaller.appspotmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [bpf?] possible deadlock in kvfree_call_rcu
Date: Sun, 31 Mar 2024 09:25:56 +0200 [thread overview]
Message-ID: <ZgkQBA-Lsk9mxZJ3@pc636> (raw)
In-Reply-To: <20240331062314.3394-1-hdanton@sina.com>
On Sun, Mar 31, 2024 at 02:23:14PM +0800, Hillf Danton wrote:
> On Sat, 30 Mar 2024 18:55:41 +0100 Uladzislau Rezki <urezki@gmail.com>
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index d9642dd06c25..8867aac3668c 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3467,19 +3467,19 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr)
> > */
> > kmemleak_ignore(ptr);
> >
> > - // Set timer to drain after KFREE_DRAIN_JIFFIES.
> > - if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING)
> > - schedule_delayed_monitor_work(krcp);
> > -
>
> This is not enough at least WRT run_page_cache_worker() [1]
>
> [1] https://lore.kernel.org/lkml/0000000000007a44120614e27cb7@google.com/
>
page-cache-worker should be move out of the krcp-lock also. I will
update the patch.
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-03-31 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 19:00 [syzbot] [bpf?] possible deadlock in kvfree_call_rcu syzbot
2024-03-26 19:53 ` false positive deadlock? Was: " Alexei Starovoitov
2024-03-27 4:37 ` Paul E. McKenney
2024-03-27 5:04 ` Paul E. McKenney
2024-03-28 0:12 ` Alexei Starovoitov
2024-03-27 23:27 ` syzbot
2024-03-28 23:07 ` Hillf Danton
2024-03-29 16:17 ` syzbot
2024-03-30 0:27 ` Hillf Danton
2024-03-30 15:34 ` syzbot
2024-03-30 23:42 ` Hillf Danton
2024-03-30 23:42 ` Hillf Danton
2024-03-31 5:43 ` syzbot
2024-03-31 6:19 ` Hillf Danton
2024-03-31 7:03 ` syzbot
2024-03-31 7:03 ` syzbot
2024-03-30 17:55 ` Uladzislau Rezki
2024-03-31 6:23 ` Hillf Danton
2024-03-31 6:23 ` Hillf Danton
2024-03-31 7:25 ` Uladzislau Rezki [this message]
2024-03-31 6:28 ` Uladzislau Rezki
2024-03-31 6:54 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgkQBA-Lsk9mxZJ3@pc636 \
--to=urezki@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=syzbot+1fa663a2100308ab6eab@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox