From: Jiri Olsa <olsajiri@gmail.com>
To: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
haoluo@google.com, sdf@google.com, kpsingh@kernel.org,
john.fastabend@gmail.com, yonghong.song@linux.dev,
song@kernel.org, eddyz87@gmail.com, andrii@kernel.org,
daniel@iogearbox.net, ast@kernel.org, martin.lau@linux.dev,
khazhy@chromium.org, vmalik@redhat.com, ndesaulniers@google.com,
ncopa@alpinelinux.org, dxu@dxuuu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
Date: Tue, 16 Apr 2024 09:28:14 +0200 [thread overview]
Message-ID: <Zh4ojsD-aV2vHROI@krava> (raw)
In-Reply-To: <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote:
> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
> > lgtm, did it actualy cause problem anywhere?
> >
> > there's also tools/include/linux/btf_ids.h
>
> It caused the problems exactly in the file
> tools/include/linux/btf_ids.h and was reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=218647
> The patch including linux/types.h in tools/include/linux/btf_ids.h is
> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
> I also faced the same compile-error of the form
>
> error: unknown type name 'u32'
> u32 cnt;
> ^~~
> when compiling the bpf tool with glibc 2.28.
>
> I think it might be reasonable to add the inclusion in
> include/linux/btf_ids.h as well to prevent build problems like this.
ok, it's in the bpf/master already
jirka
next prev parent reply other threads:[~2024-04-16 7:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 4:51 [PATCH] bpf: btf: include linux/types.h for u32 Dmitrii Bundin
2024-04-15 12:11 ` Jiri Olsa
2024-04-16 5:15 ` [PATCH bpf-next v2] " Dmitrii Bundin
2024-04-16 7:23 ` Jiri Olsa
2024-04-16 5:27 ` [PATCH] " Dmitrii Bundin
2024-04-16 7:28 ` Jiri Olsa [this message]
2024-04-16 14:47 ` Daniel Borkmann
2024-04-17 6:26 ` Dmitrii Bundin
2024-04-17 7:17 ` Jiri Olsa
2024-04-20 4:24 ` [PATCH bpf-next v3] " Dmitrii Bundin
2024-04-26 15:54 ` Daniel Borkmann
2024-04-29 23:33 ` Andrii Nakryiko
2024-04-29 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh4ojsD-aV2vHROI@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dmitrii.bundin.a@gmail.com \
--cc=dxu@dxuuu.xyz \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=khazhy@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=ncopa@alpinelinux.org \
--cc=ndesaulniers@google.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox