From: Charlie Jenkins <charlie@rivosinc.com>
To: Zhao Ke <ke.zhao@shingroup.cn>
Cc: paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
dawei.li@shingroup.cn, shenghui.qu@shingroup.cn
Subject: Re: [PATCH] Use bool value in set_cpu_online()
Date: Tue, 16 Apr 2024 11:06:21 -0700 [thread overview]
Message-ID: <Zh6+HZnsgh9ncvPj@ghost> (raw)
In-Reply-To: <20240318065404.123668-1-ke.zhao@shingroup.cn>
On Mon, Mar 18, 2024 at 02:54:04PM +0800, Zhao Ke wrote:
> The declaration of set_cpu_online() takes a bool value. So replace
> int here to make it consistent with the declaration.
>
> Signed-off-by: Zhao Ke <ke.zhao@shingroup.cn>
> ---
> arch/riscv/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> index 519b6bd946e5..3f7c274653ab 100644
> --- a/arch/riscv/kernel/smpboot.c
> +++ b/arch/riscv/kernel/smpboot.c
> @@ -229,7 +229,7 @@ asmlinkage __visible void smp_callin(void)
> riscv_ipi_enable();
>
> numa_add_cpu(curr_cpuid);
> - set_cpu_online(curr_cpuid, 1);
> + set_cpu_online(curr_cpuid, true);
>
> if (has_vector()) {
> if (riscv_v_setup_vsize())
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Thank you!
Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
next prev parent reply other threads:[~2024-04-16 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 6:54 [PATCH] Use bool value in set_cpu_online() Zhao Ke
2024-04-16 18:06 ` Charlie Jenkins [this message]
2024-05-22 23:51 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh6+HZnsgh9ncvPj@ghost \
--to=charlie@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=dawei.li@shingroup.cn \
--cc=ke.zhao@shingroup.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=shenghui.qu@shingroup.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox