From: Lennart Poettering <mzxreary@0pointer.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Linux regressions mailing list <regressions@lists.linux.dev>,
linux-block@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: API break, sysfs "capability" file
Date: Tue, 16 Apr 2024 16:18:14 +0200 [thread overview]
Message-ID: <Zh6IpqnSfGHXMjVa@gardel-login> (raw)
In-Reply-To: <d7a2b07c-26eb-4d55-8aa7-137168bd0b49@kernel.dk>
On Di, 09.04.24 09:17, Jens Axboe (axboe@kernel.dk) wrote:
> On 4/9/24 8:15 AM, Christoph Hellwig wrote:
> > On Tue, Apr 09, 2024 at 10:19:09AM +0200, Lennart Poettering wrote:
> >> All I am looking for is a very simple test that returns me a boolean:
> >> is there kernel-level partition scanning enabled on this device or
> >> not.
> >
> > And we can add a trivial sysfs attribute for that.
>
> And I think we should. I don't know what was being smoked adding a sysfs
> interface that exposed internal flag values - and honestly what was
> being smoked to rely on that, but I think it's fair to say that the
> majority of the fuckup here is on the kernel side.
Yeah, it's a shitty interface, the kernel is rich in that. But it was
excessively well documented, better in fact than almost all other
kernel interfaces:
→ https://www.kernel.org/doc/html/v5.16/block/capability.html ←
If you document something on so much detail in the API docs, how do
you expect this *not* to be relied on by userspace.
Lennart
next prev parent reply other threads:[~2024-04-16 14:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZhQJf8mzq_wipkBH@gardel-login>
2024-04-08 17:43 ` API break, sysfs "capability" file Linux regression tracking (Thorsten Leemhuis)
2024-04-08 18:41 ` Keith Busch
2024-04-08 20:23 ` Lennart Poettering
2024-04-08 22:41 ` Keith Busch
2024-04-09 6:09 ` Hannes Reinecke
2024-04-09 8:19 ` Lennart Poettering
2024-04-09 14:15 ` Christoph Hellwig
2024-04-09 15:17 ` Jens Axboe
2024-04-16 9:26 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-17 15:07 ` Christoph Hellwig
2024-04-16 14:18 ` Lennart Poettering [this message]
2024-04-16 14:22 ` Jens Axboe
2024-04-16 14:25 ` Lennart Poettering
2024-04-16 14:33 ` Jens Axboe
2024-04-24 8:09 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-25 13:08 ` Christoph Hellwig
2024-04-16 14:23 ` Lennart Poettering
2024-04-16 14:44 ` Keith Busch
2024-04-17 15:13 ` Christoph Hellwig
2024-04-17 15:48 ` Lennart Poettering
2024-04-17 15:59 ` Christoph Hellwig
2024-04-17 16:10 ` Lennart Poettering
2024-04-17 16:22 ` Christoph Hellwig
2024-04-17 16:26 ` Lennart Poettering
2024-04-17 16:38 ` Christoph Hellwig
2024-04-18 6:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh6IpqnSfGHXMjVa@gardel-login \
--to=mzxreary@0pointer.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox