Re: [PATCH 0/3] drm: Multiple documentation update

Jani Nikula
2024-04-09T10:18:08Z

On Tue, 09 Apr 2024, Louis Chauvet <louis.chauvet@bootlin.com> wrote:
> PATCH 1 and PATCH 2 focus on the rotation property. The rotation property
> can be challenging to understand, especially when it is combined with
> reflections. These patches aim to provide clearer explanations and
> examples to aid in comprehension.
>
> Patch 3 relates to the fourcc property. It includes additional details
> about block and char_per_block to provide a more comprehensive
> understanding of this feature.
>
> Regarding PATCH 1, I would appreciate some feedback on the expected
> behavior. During a recent VKMS refactor, I used drm_rect_rotate as a
> reference for the rotation. However, during my testing phase, I noticed
> that the original VKMS implementation interpreted the rotation
> differently. Therefore, I kindly request that someone validate or
> invalidate my interpretation before proceeding with the merge.

Did you run 'make htmldocs' and check the results after your changes?
I'm almost certain this botches up the layout.

BR,
Jani.

>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> Louis Chauvet (3):
> drm: drm_blend.c: Add precision in drm_rotation_simplify kernel doc
> drm: drm_blend.c: Improve drm_plane_create_rotation_property kernel doc
> drm/fourcc: Add documentation around drm_format_info
>
> drivers/gpu/drm/drm_blend.c | 57 ++++++++++++++++++++++++++++++++++-----------
> include/drm/drm_fourcc.h | 45 +++++++++++++++++++++++++++++------
> 2 files changed, 81 insertions(+), 21 deletions(-)
> ---
> base-commit: e495e523b888a6155f82c767d34c8d712a41ee54
> change-id: 20240327-google-drm-doc-cd275291792f
>
> Best regards,

--
Jani Nikula, Intel