From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD0C6F065; Wed, 17 Apr 2024 07:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713339388; cv=none; b=AuN+Ab8Xx3S4zKRjzUR2aQOZS7my4IURi0xeYAX0z1HGam+7SMsPG0KW39JlTVfj2qr+a7l7l0NbuPIKbQWWxCs+q+ZL3mfAoRQO9N2FFHq/r/ca+ycSvSmxJLu/vB3koSrrNB5Ub80Opy/Gp25AMZoB/k6ojSEAEJC+P6H1h3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713339388; c=relaxed/simple; bh=qqyNaWkr1bQ20TqnhY9ZIM5WeICxKh/paEFKiMkqgls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oo5gTHuHTlIto+MrIEUhWs9UhgM10CBuhbadV4ek/mKv+iJWSQI/0kdwJypNuSJlCJO2wP4ibLdc0sjq9RlVoeGwfOJ2FrEYuOEeJFTohdDczeSU8Cio6bPgB8j8aBtXUtBfepi6Q3TNpuw3zbs87L/fgENnJMdELYj/YuPvbbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sxpr1qaQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sxpr1qaQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0558C072AA; Wed, 17 Apr 2024 07:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713339387; bh=qqyNaWkr1bQ20TqnhY9ZIM5WeICxKh/paEFKiMkqgls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sxpr1qaQPUn8AoYZsQL3FLZLy3Fp+Q7sRKQzVEzAH6oRjIWtpAWRA2K/j/AEMQRDR prS4Nc+prxyj5nhG8W0VwBqpjYvWSS0WKYL8yFNtk+suf3pVDvsKmzejjpjehmosDR AOOFebvqA3plOBwFF9ieGcVBoFn0fffVUW2P3ZYGnwJok0x+ZRxax/3QYQbVRMKP/C HJ9RXV7ROnXDLlF+QEL0W+PyTlN/DUG9/0bpcUY+q9eIhbv1nT+c+Wo5Xn6vnXhBZK W9o8QB5y8L0gmfB39Pm2A/GkNF/djK+wkKk+wsVw5mrAug96B5AE6+U+wpvZS2X+S5 uhSRfGlwYP6+A== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rwzqE-000000007L1-3BbN; Wed, 17 Apr 2024 09:36:26 +0200 Date: Wed, 17 Apr 2024 09:36:26 +0200 From: Johan Hovold To: Chuanhong Guo Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add support for Fibocom FM650/FG650 Message-ID: References: <20240312062913.12723-1-gch981213@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Apr 15, 2024 at 10:46:52PM +0800, Chuanhong Guo wrote: > On Mon, Apr 15, 2024 at 2:46 PM Johan Hovold wrote: > > On Tue, Mar 12, 2024 at 02:29:12PM +0800, Chuanhong Guo wrote: > > > Fibocom FM650/FG650 are 5G modems with ECM/NCM/RNDIS/MBIM modes. > > In all 4 modes, the first serial port is the AT console while the other 3 > appear to be diagnostic interfaces for dumping modem logs. > > > > This patch adds support to all 4 modes. > > > > Can you please say something here about what each port (in each mode) is > > used for? > > Do I need to send a v2 for this? Generally, yes, but I amended the commit message when applying this time so no need to send a v2. Thanks! Johan