From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jonathan Corbet <corbet@lwn.net>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Mao Zhu <zhumao001@208suo.com>, Ran Sun <sunran001@208suo.com>,
Xiang wangx <wangxiang@cdjrlc.com>,
Shaomin Deng <dengshaomin@cdjrlc.com>,
Charles Han <hanchunchao@inspur.com>,
Attreyee M <tintinm2017@gmail.com>,
Linux Sound System <linux-sound@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/12] ASoC: doc: dapm: fix typos
Date: Wed, 17 Apr 2024 10:49:57 +0700 [thread overview]
Message-ID: <Zh9G5TX6682WzvbI@archie.me> (raw)
In-Reply-To: <20240416-dapm-docs-v1-1-a818d2819bf6@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]
On Tue, Apr 16, 2024 at 07:56:07AM +0200, Luca Ceresoli wrote:
> diff --git a/Documentation/sound/soc/dapm.rst b/Documentation/sound/soc/dapm.rst
> index c3154ce6e1b2..59f65b181828 100644
> --- a/Documentation/sound/soc/dapm.rst
> +++ b/Documentation/sound/soc/dapm.rst
> @@ -50,7 +50,7 @@ Stream domain
> All DAPM power switching decisions are made automatically by consulting an audio
> routing map of the whole machine. This map is specific to each machine and
> consists of the interconnections between every audio component (including
> -internal codec components). All audio components that effect power are called
> +internal codec components). All audio components that affect power are called
> widgets hereafter.
>
>
> @@ -221,7 +221,7 @@ when the Mic is inserted:-::
> Codec (BIAS) Domain
> -------------------
>
> -The codec bias power domain has no widgets and is handled by the codecs DAPM
> +The codec bias power domain has no widgets and is handled by the codec DAPM
> event handler. This handler is called when the codec powerstate is changed wrt
> to any stream event or by kernel PM events.
>
> @@ -236,7 +236,7 @@ a virtual widget - a widget with no control bits e.g.
>
> SND_SOC_DAPM_MIXER("AC97 Mixer", SND_SOC_NOPM, 0, 0, NULL, 0),
>
> -This can be used to merge to signal paths together in software.
> +This can be used to merge two signal paths together in software.
>
> After all the widgets have been defined, they can then be added to the DAPM
> subsystem individually with a call to snd_soc_dapm_new_control().
>
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-17 3:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 5:56 [PATCH 00/12] ASoC: doc: dapm: various improvements Luca Ceresoli
2024-04-16 5:56 ` [PATCH 01/12] ASoC: doc: dapm: fix typos Luca Ceresoli
2024-04-17 3:49 ` Bagas Sanjaya [this message]
2024-04-16 5:56 ` [PATCH 02/12] ASoC: doc: dapm: fix struct name Luca Ceresoli
2024-04-16 5:56 ` [PATCH 03/12] ASoC: doc: dapm: minor rewording Luca Ceresoli
2024-04-17 3:54 ` Bagas Sanjaya
2024-04-16 5:56 ` [PATCH 04/12] ASoC: doc: dapm: remove dash after colon Luca Ceresoli
2024-04-16 5:56 ` [PATCH 05/12] ASoC: doc: dapm: clarify it's an internal API Luca Ceresoli
2024-04-17 3:57 ` Bagas Sanjaya
2024-04-16 5:56 ` [PATCH 06/12] ASoC: doc: dapm: replace "map" with "graph" Luca Ceresoli
2024-04-16 5:56 ` [PATCH 07/12] ASoC: doc: dapm: extend initial descrption Luca Ceresoli
2024-04-17 4:05 ` Bagas Sanjaya
2024-04-16 5:56 ` [PATCH 08/12] ASoC: doc: dapm: describe how widgets and routes are registered Luca Ceresoli
2024-04-17 4:12 ` Bagas Sanjaya
2024-04-16 5:56 ` [PATCH 09/12] ASoC: doc: dapm: fix and improve section "Registering DAPM controls" Luca Ceresoli
2024-04-17 4:16 ` Bagas Sanjaya
2024-04-16 5:56 ` [PATCH 10/12] ASoC: doc: dapm: improve section "Codec/DSP Widget Interconnections" Luca Ceresoli
2024-04-17 4:33 ` Bagas Sanjaya
2024-04-17 5:08 ` Luca Ceresoli
2024-04-16 5:56 ` [PATCH 11/12] ASoC: doc: dapm: update section "DAPM Widget Events" Luca Ceresoli
2024-04-16 5:56 ` [PATCH 12/12] ASoC: doc: dapm: update event types Luca Ceresoli
2024-04-16 21:23 ` [PATCH 00/12] ASoC: doc: dapm: various improvements Alexandre Belloni
2024-04-17 5:07 ` Luca Ceresoli
2024-04-17 23:30 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh9G5TX6682WzvbI@archie.me \
--to=bagasdotme@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dengshaomin@cdjrlc.com \
--cc=hanchunchao@inspur.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=perex@perex.cz \
--cc=sunran001@208suo.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tintinm2017@gmail.com \
--cc=tiwai@suse.com \
--cc=wangxiang@cdjrlc.com \
--cc=zhumao001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox