[PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

[PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

[Guanbing Huang]

From: Guanbing Huang <albanhuang@tencent.com>

The 16550a serial port based on the ACPI table requires obtaining the
reg-shift attribute. In the ACPI scenario, If the reg-shift property
is not configured like in DTS, the 16550a serial driver cannot read or
write controller registers properly during initialization.

To address the issue of configuring the reg-shift property, the 
__uart_read_properties() universal interface is called to implement it.
Adaptation of PNP devices is done in the __uart_read_properties() function.

Guanbing Huang (3):
  PNP: Add dev_is_pnp() macro
  serial: port: Add support of PNP IRQ to __uart_read_properties()
  serial: 8250_pnp: Support configurable reg shift property

 drivers/tty/serial/8250/8250_pnp.c | 40 +++++++++++++++++++-----------
 drivers/tty/serial/serial_port.c   |  7 +++++-
 include/linux/pnp.h                |  2 ++
 3 files changed, 33 insertions(+), 16 deletions(-)

-- 
2.17.1

Re: [PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

[Andy Shevchenko]

On Mon, Apr 08, 2024 at 11:36:21AM +0800, Guanbing Huang wrote:
> From: Guanbing Huang <albanhuang@tencent.com>
> 
> The 16550a serial port based on the ACPI table requires obtaining the
> reg-shift attribute. In the ACPI scenario, If the reg-shift property
> is not configured like in DTS, the 16550a serial driver cannot read or
> write controller registers properly during initialization.
> 
> To address the issue of configuring the reg-shift property, the 
> __uart_read_properties() universal interface is called to implement it.
> Adaptation of PNP devices is done in the __uart_read_properties() function.

Seems okay to me now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

[Andy Shevchenko]

On Mon, Apr 08, 2024 at 06:10:13PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 08, 2024 at 11:36:21AM +0800, Guanbing Huang wrote:
> > From: Guanbing Huang <albanhuang@tencent.com>
> > 
> > The 16550a serial port based on the ACPI table requires obtaining the
> > reg-shift attribute. In the ACPI scenario, If the reg-shift property
> > is not configured like in DTS, the 16550a serial driver cannot read or
> > write controller registers properly during initialization.
> > 
> > To address the issue of configuring the reg-shift property, the 
> > __uart_read_properties() universal interface is called to implement it.
> > Adaptation of PNP devices is done in the __uart_read_properties() function.
> 
> Seems okay to me now,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Note, you have an issue with your email server. The cover letter is not chained
with the patch series. You really want to fix that if you wish to contribute
to Linux kernel project via respective mailing lists.

-- 
With Best Regards,
Andy Shevchenko