From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Pavan Holla <pholla@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v4 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver
Date: Tue, 9 Apr 2024 18:47:23 +0800 [thread overview]
Message-ID: <ZhUcu1k0Cum-IMVQ@google.com> (raw)
In-Reply-To: <20240409-public-ucsi-h-v4-2-e770735222a2@chromium.org>
On Tue, Apr 09, 2024 at 02:27:37AM +0000, Pavan Holla wrote:
> Implementation of a UCSI transport driver for ChromeOS.
The patch generally looks good to me just a few nits.
> This driver will be loaded if the ChromeOS EC implements a PPM.
Replied in v3, the patch (and the series) don't reflect the message.
> diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> [...]
> +static void cros_ucsi_work(struct work_struct *work)
> +{
> + struct cros_ucsi_data *udata = container_of(work, struct cros_ucsi_data, work);
> + u32 cci;
> + int ret;
> +
> + ret = cros_ucsi_read(udata->ucsi, UCSI_CCI, &cci, sizeof(cci));
> + if (ret)
> + return;
`ret` can be dropped.
> +static const struct platform_device_id cros_ucsi_id[] = {
> + { DRV_NAME, 0},
To be neat, append an extra space after `0`.
next prev parent reply other threads:[~2024-04-09 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 2:27 [PATCH v4 0/2] usb: typec: Implement UCSI driver for ChromeOS Pavan Holla
2024-04-09 2:27 ` [PATCH v4 1/2] platform/chrome: Update ChromeOS EC header for UCSI Pavan Holla
2024-04-09 2:27 ` [PATCH v4 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver Pavan Holla
2024-04-09 10:47 ` Tzung-Bi Shih [this message]
2024-04-10 22:14 ` Pavan Holla
2024-04-09 15:16 ` Greg Kroah-Hartman
2024-04-10 22:27 ` Pavan Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhUcu1k0Cum-IMVQ@google.com \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox