From: Jiri Olsa <olsajiri@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Andrei Vagin <avagin@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf bench uprobe: Remove lib64 from libc.so.6 binary path
Date: Wed, 10 Apr 2024 09:18:44 +0200 [thread overview]
Message-ID: <ZhY8xzVJ6_9BI-Vd@krava> (raw)
In-Reply-To: <20240406040911.1603801-1-irogers@google.com>
On Fri, Apr 05, 2024 at 09:09:10PM -0700, Ian Rogers wrote:
> bpf_program__attach_uprobe_opts will search LD_LIBRARY_PATH and so
> specifying `/lib64` is unnecessary and causes failures for libc.so.6
> paths like `/lib/x86_64-linux-gnu/libc.so.6`.
>
> Fixes: 7b47623b8cae ("perf bench uprobe trace_printk: Add entry attaching an BPF program that does a trace_printk")
> Signed-off-by: Ian Rogers <irogers@google.com>
patchset lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> tools/perf/bench/uprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/bench/uprobe.c b/tools/perf/bench/uprobe.c
> index 5c71fdc419dd..b722ff88fe7d 100644
> --- a/tools/perf/bench/uprobe.c
> +++ b/tools/perf/bench/uprobe.c
> @@ -47,7 +47,7 @@ static const char * const bench_uprobe_usage[] = {
> #define bench_uprobe__attach_uprobe(prog) \
> skel->links.prog = bpf_program__attach_uprobe_opts(/*prog=*/skel->progs.prog, \
> /*pid=*/-1, \
> - /*binary_path=*/"/lib64/libc.so.6", \
> + /*binary_path=*/"libc.so.6", \
> /*func_offset=*/0, \
> /*opts=*/&uprobe_opts); \
> if (!skel->links.prog) { \
> --
> 2.44.0.478.gd926399ef9-goog
>
next prev parent reply other threads:[~2024-04-10 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 4:09 [PATCH v1 1/2] perf bench uprobe: Remove lib64 from libc.so.6 binary path Ian Rogers
2024-04-06 4:09 ` [PATCH v1 2/2] perf bench uprobe: Add uretprobe variant of uprobe benchmarks Ian Rogers
2024-04-10 7:18 ` Jiri Olsa [this message]
2024-04-12 20:52 ` [PATCH v1 1/2] perf bench uprobe: Remove lib64 from libc.so.6 binary path Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhY8xzVJ6_9BI-Vd@krava \
--to=olsajiri@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=avagin@google.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox