From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43ABC155300; Wed, 10 Apr 2024 10:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712745058; cv=none; b=LKgj5k/i8FHx4+ZFTIL8KqQDsKnOQM7fy/jyDPz0WLDtMxNBo+6LcrqbUj+OBL3fpMdHW8hUGCMDLHfUL8U7gsgAfV4Hyn1Da+JMmXNuIeGxRiPxHGKabAXmJs8HYrGRCTE/aUPSKj5ZM0tBjhr0OJagCjPVPh50FQfzHrPbAok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712745058; c=relaxed/simple; bh=4zuUE+4lnuT1tggaLbfb0fGKSWl4GwtjbvM5H87GdGU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m1P07yBi6h6iGorxPFxzEaNXZVTf34wUyPWJdDnntU8gSbd+58XOGjlJDLv+/hiO511W7F9rgNdoEdyJg98P6TluNKgmY0FI8KHTWD7qRMW2b9vN3ZdS7tpziLH7BZvqg5Y+YAV2hr8y+omfzeGqZpSY9s1uuGYyLU3juukCtRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F1JIqt1D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F1JIqt1D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF4D2C433F1; Wed, 10 Apr 2024 10:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712745058; bh=4zuUE+4lnuT1tggaLbfb0fGKSWl4GwtjbvM5H87GdGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F1JIqt1DYu/EdX9xeaqocx0Ee4XY2rYzbMa07kVMga9FMWIqgSn0V3gAVx5RypX6Y KDwK6xQmNHyTvCbQ3c7vPKe9WOSPZJlKvDJiXUFDiRPEysAmX6XTZq1QTbwPQU8j1o Wad+4UCUk323tDaC20zdvVPwq6ECB6GCwS02zVoo9Tfc04W0vZK4285mTsBTidFzuf HFdHRXc1lkdZA5Jo8r063Lv8buZ4+zOn76deLqCbYHFjxqq6FDHd7tLTgT4/dDBZvj 7uGxqGrbM8a4IIeG2Z2sNPe3JWEqeyKcnSpfNA9F6Cbn4CFa/dnFC+5/hpEIOp09fY DNjOwSzBq7DJg== Date: Wed, 10 Apr 2024 12:30:55 +0200 From: Frederic Weisbecker To: "Paul E. McKenney" Cc: Valentin Schneider , rcu@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang Subject: Re: [PATCH 2/2] context_tracking, rcu: Rename RCU_DYNTICKS_IDX to CT_DYNTICKS_IDX Message-ID: References: <20240327112902.1184822-1-vschneid@redhat.com> <20240327112902.1184822-3-vschneid@redhat.com> <1ef9d1f9-16a2-4ddc-abd5-6c3b7cde290f@paulmck-laptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1ef9d1f9-16a2-4ddc-abd5-6c3b7cde290f@paulmck-laptop> Le Tue, Apr 09, 2024 at 12:53:03PM -0700, Paul E. McKenney a écrit : > On Thu, Apr 04, 2024 at 03:38:40PM +0200, Frederic Weisbecker wrote: > > Le Wed, Mar 27, 2024 at 12:29:02PM +0100, Valentin Schneider a écrit : > > > The symbols relating to the CT_STATE part of context_tracking.state are now > > > all prefixed with CT_STATE. > > > > > > The RCU dynticks counter part of that atomic variable still involves > > > symbols with different prefixes, align them all to be prefixed with > > > CT_DYNTICKS, as CT_DYNTICKS_MASK already is. > > > > > > Signed-off-by: Valentin Schneider > > > > It used to be that RCU extended quiescent state and dynticks enter/exit > > were coupled. But this isn't the case anymore. Nowadays RCU stops watching > > some time later after dynticks is entered. > > I knew that consolidation of atomic operations was too good to last... > > > I wonder if we shouldn't take advantage of that cleanup for a meaning that > > really reflect that RCU stops watching from there. > > > > Paul what do you think? CT_EQS_IDX ? CT_RCUEQS_IDX? CT_RCUOFF_IDX? ...? > > "After what you just did? You can just RCU off!!!" > > Sorry, couldn't resist... > > I am having a hard time getting too excited about the name. I could > suggest CT_RCU_WATCHING_IDX, but that isn't exactly the shortest > possible name. I really like CT_RCU_WATCHING. It says everything. The _IDX isn't even needed after all. What do you think? Thanks. > Thanx, Paul