Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function

Dave Martin
2024-04-11T14:14:45Z

On Wed, Apr 03, 2024 at 07:51:54AM +0000, Shaopeng Tan (Fujitsu) wrote:
> Hello James,
>
> > rdtgroup_init() needs exporting so that arch code can call it once it lives in core
> > code. As this is one of the few functions we export, rename it to have the resctrl
> > in the name. The same goes for the exit call.
> >
> > x86's arch code init functions for RDT are renamed to have an arch prefix to
> > make it clear these are part of the architecture code.
> >
> > Signed-off-by: James Morse <james.morse@arm.com>
> > ---
> > arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++------
> > arch/x86/kernel/cpu/resctrl/internal.h | 3 ---
> > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 8 ++++----
> > include/linux/resctrl.h | 3 +++
> > 4 files changed, 13 insertions(+), 13 deletions(-)
>
> /fs/resctrl/monitor.c
> 746 * RESCTRL_RESERVED_CLOSID and RESCTRL_RESERVED_RMID are special and
> 747 * are always allocated. These are used for the rdtgroup_default
> 748 * control group, which will be setup later in rdtgroup_init().
> "rdtgroup_init()" is still in the comments.
>
>
> Best regards,
> Shaopeng TAN
>

[...]

Noted for James' attention, thanks.

Cheers
---Dave