Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*_enabled() helpers to asm/resctrl.h

Dave Martin
2024-04-11T14:16:25Z

On Mon, Apr 08, 2024 at 08:20:12PM -0700, Reinette Chatre wrote:
> Hi James,
>
> On 3/21/2024 9:50 AM, James Morse wrote:
> > The architecture specific parts of resctrl have helpers to hide accesses
> > to the rdt_mon_features bitmap.
> >
> > Once the filesystem parts of resctrl are moved, these can no longer live
> > in internal.h. Once these are exposed to the wider kernel, they should
> > have a 'resctrl_arch_' prefix, to fit the rest of the arch<->fs interface.
> >
> > Move and rename the helpers that touch rdt_mon_features directly.
> > is_mbm_event() and is_mbm_enabled() are only called from rdtgroup.c,
> > so can be moved into that file.
> >
> > Signed-off-by: James Morse <james.morse@arm.com>
> > ---
> > arch/x86/include/asm/resctrl.h | 17 +++++++++++
> > arch/x86/kernel/cpu/resctrl/core.c | 4 +--
> > arch/x86/kernel/cpu/resctrl/internal.h | 27 -----------------
> > arch/x86/kernel/cpu/resctrl/monitor.c | 18 ++++++------
> > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 40 +++++++++++++++++---------
> > 5 files changed, 54 insertions(+), 52 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
> > index 5f6a5375bb4a..50407e83d0ca 100644
> > --- a/arch/x86/include/asm/resctrl.h
> > +++ b/arch/x86/include/asm/resctrl.h
> > @@ -7,6 +7,7 @@
> > #include <linux/jump_label.h>
> > #include <linux/percpu.h>
> > #include <linux/sched.h>
> > +#include <linux/resctrl_types.h>
> >
>
> Can this be alphabetical?

I'd guess so, looking at it.

Noted.

Cheers
---Dave