From: Sudeep Holla <sudeep.holla@arm.com>
To: Yunhui Cui <cuiyunhui@bytedance.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, bhelgaas@google.com,
james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com,
john.garry@huawei.com, Jonathan.Cameron@huawei.com,
pierre.gondois@arm.com, tiantao6@huawei.com
Subject: Re: [PATCH v2 1/3] riscv: cacheinfo: remove the useless parameter (node) of ci_leaf_init()
Date: Mon, 15 Apr 2024 09:47:05 +0100 [thread overview]
Message-ID: <ZhzpiWFCSvWWTqxx@bogus> (raw)
In-Reply-To: <20240414025826.64025-1-cuiyunhui@bytedance.com>
On Sun, Apr 14, 2024 at 10:58:24AM +0800, Yunhui Cui wrote:
> The implementation of the ci_leaf_init() function body and the caller
> do not use the input parameter (struct device_node *node), so remove it.
>
> Fixes: 6a24915145c9 ("Revert "riscv: Set more data to cacheinfo"")
Not sure if this can be tagged as fix, but I leave that to RISC-V maintainers.
With the comment in PATCH 2/3 fixed based on your experiment, feel free
to add to the whole series,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
prev parent reply other threads:[~2024-04-15 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 2:58 [PATCH v2 1/3] riscv: cacheinfo: remove the useless parameter (node) of ci_leaf_init() Yunhui Cui
2024-04-14 2:58 ` [PATCH v2 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT Yunhui Cui
2024-04-15 8:44 ` Sudeep Holla
2024-04-15 12:03 ` [External] " yunhui cui
2024-04-15 13:21 ` Sudeep Holla
2024-04-14 2:58 ` [PATCH v2 3/3] RISC-V: Select ACPI PPTT drivers Yunhui Cui
2024-04-15 8:47 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhzpiWFCSvWWTqxx@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=cuiyunhui@bytedance.com \
--cc=james.morse@arm.com \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox