From: Johan Hovold <johan@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function
Date: Tue, 23 Apr 2024 14:02:23 +0200 [thread overview]
Message-ID: <ZiejT5yddioQ8upR@hovoldconsulting.com> (raw)
In-Reply-To: <20240422134354.89291-3-srinivas.kandagatla@linaro.org>
On Mon, Apr 22, 2024 at 02:43:52PM +0100, Srinivas Kandagatla wrote:
> static const struct snd_soc_dapm_widget qcom_jack_snd_widgets[] = {
> SND_SOC_DAPM_HP("Headphone Jack", NULL),
> SND_SOC_DAPM_MIC("Mic Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP0 Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP1 Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP2 Jack", NULL),
Shouldn't these be split in dedicated HDMI and DP jacks too? What if you
have a machine with HDMI and DP jacks which would otherwise both claim
"HDMI/DP0"?
Johan
next prev parent reply other threads:[~2024-04-23 12:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:43 [PATCH v2 0/4] ASoC: qcom: display port changes srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 1/4] ASoC: qcom: q6dsp: parse Display port tokens srinivas.kandagatla
2024-04-22 13:43 ` [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function srinivas.kandagatla
2024-04-23 11:44 ` Johan Hovold
2024-04-23 12:02 ` Johan Hovold [this message]
2024-04-23 15:55 ` Srinivas Kandagatla
2024-04-29 14:54 ` Johan Hovold
2024-05-09 8:59 ` Srinivas Kandagatla
2024-05-30 22:38 ` Dmitry Baryshkov
2024-05-31 6:44 ` Srinivas Kandagatla
2024-04-22 13:43 ` [PATCH v2 3/4] ASoC: qcom: sc8280xp: add Display port Jack srinivas.kandagatla
2024-04-23 11:48 ` Johan Hovold
2024-05-30 22:41 ` Dmitry Baryshkov
2024-04-22 13:43 ` [PATCH v2 4/4] ASoC: qcom: sm8250: fix a typo in function name srinivas.kandagatla
2024-04-23 11:59 ` [PATCH v2 0/4] ASoC: qcom: display port changes Johan Hovold
2024-04-23 12:38 ` Srinivas Kandagatla
2024-04-23 14:58 ` Johan Hovold
2024-04-23 15:59 ` Srinivas Kandagatla
2024-04-29 15:00 ` Johan Hovold
2024-05-30 22:56 ` Dmitry Baryshkov
2024-05-23 4:09 ` Xilin Wu
2024-05-24 12:50 ` Srinivas Kandagatla
2024-05-25 7:12 ` Xilin Wu
2024-06-06 9:18 ` Srinivas Kandagatla
2024-06-08 11:41 ` Xilin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiejT5yddioQ8upR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox