From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION()
Date: Tue, 23 Apr 2024 16:03:51 +0300 [thread overview]
Message-ID: <Ziext29Er2PHb4Ud@smile.fi.intel.com> (raw)
In-Reply-To: <ZiegXwf0zK_cIhdR@siri.cascardo.eti.br>
On Tue, Apr 23, 2024 at 08:49:51AM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote:
> > The modpost script is not happy
> >
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
> >
> > because there is a missing module description.
> >
> > Add it to the module.
...
> > +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices");
>
> How about "Support for Intel Classmate PC ACPI devices", like the
> Kconfig devices?
Whatever maintainers prefer.
Thank you for looking into this.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-23 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 15:12 [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION() Andy Shevchenko
2024-04-23 11:49 ` Thadeu Lima de Souza Cascardo
2024-04-23 13:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziext29Er2PHb4Ud@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cascardo@holoscopio.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox