* [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION()
@ 2024-04-22 15:12 Andy Shevchenko
2024-04-23 11:49 ` Thadeu Lima de Souza Cascardo
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-04-22 15:12 UTC (permalink / raw)
To: Rafael J. Wysocki, Andy Shevchenko, Krzysztof Kozlowski,
platform-driver-x86, linux-kernel
Cc: Thadeu Lima de Souza Cascardo, Hans de Goede, Ilpo Järvinen
The modpost script is not happy
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
because there is a missing module description.
Add it to the module.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/classmate-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 87462e7c6219..fb208c68a7eb 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -13,8 +13,6 @@
#include <linux/input.h>
#include <linux/rfkill.h>
-MODULE_LICENSE("GPL");
-
struct cmpc_accel {
int sensitivity;
int g_select;
@@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
};
MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
+MODULE_DESCRIPTION("Support for Classmate PC ACPI devices");
+MODULE_LICENSE("GPL");
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION()
2024-04-22 15:12 [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION() Andy Shevchenko
@ 2024-04-23 11:49 ` Thadeu Lima de Souza Cascardo
2024-04-23 13:03 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2024-04-23 11:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, Krzysztof Kozlowski, platform-driver-x86,
linux-kernel, Hans de Goede, Ilpo Järvinen
On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote:
> The modpost script is not happy
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
>
> because there is a missing module description.
>
> Add it to the module.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/platform/x86/classmate-laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 87462e7c6219..fb208c68a7eb 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -13,8 +13,6 @@
> #include <linux/input.h>
> #include <linux/rfkill.h>
>
> -MODULE_LICENSE("GPL");
> -
> struct cmpc_accel {
> int sensitivity;
> int g_select;
> @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
> };
>
> MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
> +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices");
How about "Support for Intel Classmate PC ACPI devices", like the
Kconfig devices?
Cascardo.
> +MODULE_LICENSE("GPL");
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION()
2024-04-23 11:49 ` Thadeu Lima de Souza Cascardo
@ 2024-04-23 13:03 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-04-23 13:03 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: Rafael J. Wysocki, Krzysztof Kozlowski, platform-driver-x86,
linux-kernel, Hans de Goede, Ilpo Järvinen
On Tue, Apr 23, 2024 at 08:49:51AM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote:
> > The modpost script is not happy
> >
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
> >
> > because there is a missing module description.
> >
> > Add it to the module.
...
> > +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices");
>
> How about "Support for Intel Classmate PC ACPI devices", like the
> Kconfig devices?
Whatever maintainers prefer.
Thank you for looking into this.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-23 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 15:12 [PATCH v1 1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION() Andy Shevchenko
2024-04-23 11:49 ` Thadeu Lima de Souza Cascardo
2024-04-23 13:03 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox