From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E786613BAFE; Tue, 23 Apr 2024 15:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713887138; cv=none; b=U3bV3vEXhgvoKc8aoazlyISTeQeLVc4q0U5mSN1cDlof/SpBzRybNExPmIFjHfr4SGSpXCRstph2G9WRoVPOdFnhsAnx51kZFlW7ckIL/Ka8X5RUtrgnrpVzClTFtVJNXoAeBPBRInxcB8rGzsIvwKgUG9GPoc9w5vIIzXBZDPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713887138; c=relaxed/simple; bh=g32tYyNwhHSjBI5XP117/+DCw7CjmkPynMd0Zm5xQ90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FT3Qp7hjVyhdU2QfOlMxjS/5SW5MgH+TPyGrqv5Q+A8LJNUkp02SmnD9Djz/8ktYnTJwzN8lPovp3gaH5A/1TBe4WgHXMSCdw3hQJx3pkxClvrBIqEnOKtuT4U+5nqLFD+VJCAlgotJdyuqJ4ZUs5vlstvRSgZge2Z5rqX3t9eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ggWjpk4C; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ggWjpk4C" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713887137; x=1745423137; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g32tYyNwhHSjBI5XP117/+DCw7CjmkPynMd0Zm5xQ90=; b=ggWjpk4Ct7tHV5h6/c6+gxgmAT0bXAdXexTj1a7rrLdLTe3wqJCYRLbQ +VwyEL13lwMOtP3w1nuwoNFORMY851OB11Gxz7yRtAibBs3zREjTHs9lZ 5PYJo6DUWwzEz2YwVJziI4cEBdI6PprP+7sz93Vs37qytUdzl7/T9FIVm 3QUyttbeHv1CxDrRnmOgZvkc5TnNBJd3+PDqZ9WhKDEm8ENEQ9BQcajMQ crF6NCshWksNT1NuJimpG4mM2AhP45Ktv3qYKtTtZ3PJBw8wyQesmdjW4 /DadMWFqONqCsIpdmm61ZJY+PR3BRv7R+qLvi1cRyUZBN8SBkakyUmoQf w==; X-CSE-ConnectionGUID: vQ715DZKRS2dfrtPniylZQ== X-CSE-MsgGUID: sqniNEsySf6Uob+NUsD01g== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="13265074" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="13265074" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 08:45:36 -0700 X-CSE-ConnectionGUID: NS7n0LC0RDaT5M1xEcfcrQ== X-CSE-MsgGUID: R/YEB9pyR/e0vS5U8r4puA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24441163" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 08:45:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzIKo-00000000Ndc-2YC6; Tue, 23 Apr 2024 18:45:30 +0300 Date: Tue, 23 Apr 2024 18:45:30 +0300 From: Andy Shevchenko To: nuno.sa@analog.com Cc: Petr Mladek , Chris Down , John Ogness , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Olivier Moysan , Andi Shyti , Jyoti Bhayana , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers Message-ID: References: <20240423-dev-add_dev_errp_probe-v2-0-12f43c5d8b0d@analog.com> <20240423-dev-add_dev_errp_probe-v2-1-12f43c5d8b0d@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Apr 23, 2024 at 06:31:20PM +0300, Andy Shevchenko wrote: > On Tue, Apr 23, 2024 at 05:20:30PM +0200, Nuno Sa via B4 Relay wrote: > > From: Nuno Sa ... > > +#define dev_err_cast_probe(dev, ___err_ptr, fmt, ...) ({ \ > > + ERR_PTR(dev_err_probe(dev, PTR_ERR(___err_ptr), fmt, ##__VA_ARGS__)); \ > > +}) After looking into the next patch I think this should be rewritten to use %pe, hence should be an exported function. Or dev_err_probe() should be split to a version that makes the difference between int and const void * (maybe using _Generic()). -- With Best Regards, Andy Shevchenko