Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

Johannes Weiner
2024-04-23T20:30:22Z

On Tue, Apr 23, 2024 at 09:27:07PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote:
> > On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > In some configurations I got
> > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > > Becuase the only user is guarged with a certain ifdeffery,
> > > do the same for add_to_free_list().
>
> ...
>
> > Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate
> > free page accounting".
>
> Thank you!

Thanks for the fix. We switched most callsites to __add_to_free_list()
now, I didn't realize the memory failure code was the only one left.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>