From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v2 1/1] ALSA: control: Use list_for_each_entry_safe()
Date: Wed, 24 Apr 2024 17:49:48 +0300 [thread overview]
Message-ID: <ZikcDLDnv1PX17wb@smile.fi.intel.com> (raw)
In-Reply-To: <87h6frdxz2.wl-tiwai@suse.de>
On Wed, Apr 24, 2024 at 09:24:49AM +0200, Takashi Iwai wrote:
> On Tue, 23 Apr 2024 23:10:22 +0200,
> Andy Shevchenko wrote:
> >
> > Instead of reiterating the list, use list_for_each_entry_safe()
> > that allows to continue without starting over.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Jaroslav Kysela <perex@perex.cz>
> > ---
> > v2: added tag (Jaroslav)
>
> We have a similar repeat in snd_ctl_led_reset().
> Wouldn't it be better to catch both?
Sure, v3 is on its way.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-24 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 21:10 [PATCH v2 1/1] ALSA: control: Use list_for_each_entry_safe() Andy Shevchenko
2024-04-24 7:24 ` Takashi Iwai
2024-04-24 14:49 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-29 14:23 Andy Shevchenko
2023-08-29 17:50 ` kernel test robot
2023-08-29 19:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikcDLDnv1PX17wb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox