From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA14B15B107 for ; Wed, 24 Apr 2024 16:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713975210; cv=none; b=I8A3VTW/K05sfEQzYmzDU86EgPkcQyEH1asHD0ILMJgC7okKikRQ9RfL9EuTMdwPERY9J/4UCZc6qgw8MS6M4oxaqiQ2FU9oijoMu7Qd/28qt8cFNy8P1rUMgy0brArG0dwRGnxAI1lKyMNP8U3W4Lx6kg5OwsDQE/ZTtQ3tXks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713975210; c=relaxed/simple; bh=LWAdr7sNhwS/CNPenio+nMszXGBrLvqRUUDAm9TzMRQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jxkp8oRbqQ5uTPdAezHPG4iw5mojCOe9ngKUnqtRg7ZJ+aLqEZdCZWrgyMa3/EFZu1zBJWlyA9yL4bGLguLF1l5Yf4aGs3HjyxwemDrObzlJtLn5xx66E41VRF7g/Ml6Gg6oB3eSDTgmoRCRMDwlZ0h3FopN1T0MCqzd06GW4cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hPjtlIT6; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hPjtlIT6" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-6f3844500a5so63045b3a.3 for ; Wed, 24 Apr 2024 09:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713975208; x=1714580008; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=PaA4wyLmEeZNOg80inX0PuP1bfRa+x1yCphxcXdPVro=; b=hPjtlIT6PgLW+bzEXKypv38tBnheBFqHe95iWB3Fr0JsxB1302SuLFz+Fd780z6y8+ N7V1YLrkvBtRcYnkgjWM3rIW69ClIgB0+EHBbEXp8Z+6PqSwD/9OlA6Z7MjY9+jq6jgk GzjDtHSSgOiUroBWFgTkDjHihzvirZDiPXDaTo5yOHHuDhMZ/ug3Gn+wHImqP39z9MLl vcA3CdjtKAzPIMowa0kZLwGHRDDdVOe9nsgX5JsB4oFS3QGj82echJEZ5sLVVpF+wTr8 AF3ZtNfP72Hsfb66ox4Dqifs0WCOI9JUF1PlDoyZ1bJvDuR70sVuZMRh+uq/YqQvPglF gyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713975208; x=1714580008; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PaA4wyLmEeZNOg80inX0PuP1bfRa+x1yCphxcXdPVro=; b=pInqo8gdHlxnyEAQpyilgni699a5HR6MFc1gW2E8Ughc+EtARnltwBEpdX813+6O7n H9GUytIXSTlXF5bWk3thkkD0RJMZ+OCD7BLNvszdGY7cg//MYQkyXxPSwYYEU+b7aYeG BQeC18uIFXKHxivXqZEjkdoF6r4HAh//O3YJzF/BSroEQfyDH7CH6plqtH9cQc+zQ+pe EgQb/0R76SpIviDrpjsR2jP8UFwZnllRI+8KkNArkVzXfbHNKFxkdhWtX0yJUnqqxymm xxCFxjufRMJQtYKLs6Zg+/Qay24lAonw1xRXWDlFdzsdn3EBn8+dHSwA0muiFaGXf/rQ 9exQ== X-Forwarded-Encrypted: i=1; AJvYcCVjwqnP+jiVlTpVJdvw/wHcU3iYCfo1/VHUZFQlm/xrNDSLmrBa+xwGaBBNt3XZo7ZKJbWC4dCfjJGmKVLXpD1jC6vk9+8bEOUHq80p X-Gm-Message-State: AOJu0YzZe3A1oybNMBXbnw/kks/Z1xjIJUp2EcUxNzEJV1bLmDR9LkGt LxlaPb08aMlTKwHUOK4Rmx8L+RqAQjdR+NeMZ/OfxbmirrzpZ3UwINZNX90CEG2x5zNsjzuXYP1 Mhg== X-Google-Smtp-Source: AGHT+IGcH9Ew/i2TenHG22Ht2ZajYli2cHigwOlMHHn2UBTTXvMnBBQr0XVBCFOVW2KZ/Dmr6S2qlvHy+Tc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:2450:b0:6ed:d14e:a1b9 with SMTP id d16-20020a056a00245000b006edd14ea1b9mr273950pfj.0.1713975208058; Wed, 24 Apr 2024 09:13:28 -0700 (PDT) Date: Wed, 24 Apr 2024 09:13:26 -0700 In-Reply-To: <6fae9b07de98d7f56b903031be4490490042ff90.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <6fae9b07de98d7f56b903031be4490490042ff90.camel@intel.com> Message-ID: Subject: Re: [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable From: Sean Christopherson To: Rick P Edgecombe Cc: "jmattson@google.com" , Chao Gao , "vkuznets@redhat.com" , Vishal Annapurve , Reinette Chatre , Xiaoyao Li , Erdem Aktas , "pbonzini@redhat.com" , "mlevitsk@redhat.com" , Isaku Yamahata , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" On Tue, Apr 16, 2024, Rick P Edgecombe wrote: > On Thu, 2024-03-21 at 09:37 -0700, Reinette Chatre wrote: > > > > Summary > > ------- > > Add KVM_CAP_X86_APIC_BUS_FREQUENCY capability to configure the APIC > > bus clock frequency for APIC timer emulation. > > Allow KVM_ENABLE_CAPABILITY(KVM_CAP_X86_APIC_BUS_FREQUENCY) to set the > > frequency in nanoseconds. When using this capability, the user space > > VMM should configure CPUID leaf 0x15 to advertise the frequency. > > Looks good to me and... > Tested-by: Rick Edgecombe > > The only thing missing is actually integrating it into TDX qemu patches and > testing the resulting TD. I think we are making a fair assumption that the > problem should be resolved based on the analysis, but we have not actually > tested that part. Is that right? Please tell me that Rick is wrong, and that this actually has been tested with a TDX guest. I don't care _who_ tested it, or with what VMM it has been tested, but _someone_ needs to verify that this actually fixes the TDX issue.