Re: [RFC][PATCH] uprobe: support for private hugetlb mappings

David Hildenbrand
2024-05-16T19:52:17Z

On 16.05.24 19:44, Guillaume Morin wrote:
> On 02 May 5:59, Guillaume Morin wrote:
>>
>> On 30 Apr 21:25, David Hildenbrand wrote:
>>>> I tried to get the hugepd stuff right but this was the first I heard
>>>> about it :-) Afaict follow_huge_pmd and friends were already DTRT
>>>
>>> I'll have to have a closer look at some details (the hugepd writability
>>> check looks a bit odd), but it's mostly what I would have expected!
>>
>> Ok in the meantime, here is the uprobe change on your current
>> uprobes_cow trying to address the comments you made in your previous
>> message. Some of them were not 100% clear to me, so it's a best effort
>> patch :-) Again lightly tested
>
> David, have you had a chance to take a look at both patches?

Not in detail, last weeks were busy (currently traveling back home from
LSF/MM). I'll try to find time within the next two weeks to polish my
changes and send them out. It would be great if you could send your
stuff based on top of that then.

(the merge window just opened on Saturday, so we have plenty of time to
make it to the next one :) )

--
Cheers,

David / dhildenb