Re: [RFC][PATCH] uprobe: support for private hugetlb mappings

Guillaume Morin
2024-05-16T17:45:20Z

On 02 May 5:59, Guillaume Morin wrote:
>
> On 30 Apr 21:25, David Hildenbrand wrote:
> > > I tried to get the hugepd stuff right but this was the first I heard
> > > about it :-) Afaict follow_huge_pmd and friends were already DTRT
> >
> > I'll have to have a closer look at some details (the hugepd writability
> > check looks a bit odd), but it's mostly what I would have expected!
>
> Ok in the meantime, here is the uprobe change on your current
> uprobes_cow trying to address the comments you made in your previous
> message. Some of them were not 100% clear to me, so it's a best effort
> patch :-) Again lightly tested

David, have you had a chance to take a look at both patches?