Re: [PATCH v22 5/5] ring-buffer/selftest: Add ring-buffer mapping test

Steven Rostedt
2024-05-07T23:35:57Z

On Fri, 3 May 2024 13:12:56 -0600
Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 4/30/24 05:13, Vincent Donnefort wrote:
> > This test maps a ring-buffer and validate the meta-page after reset and
> > after emitting few events.
> >
>
> Changelog needs to be imperative - refer to the following:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> Update the change log and describe what the test does and include
> test output.
>
> If the test requires root privileges - make sure add a check to skip
> when a normal use runs the test.
>
> The rest looks good.
>

Vincent,

Can you address Shuah's concerns. I'm starting to test patches 1-4 so
you only need to send an update to this one, unless of course I find an
issue with one of the others.

Thanks,

-- Steve